Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for #42882 #43011

Merged
merged 2 commits into from
Oct 10, 2024
Merged

Fix for #42882 #43011

merged 2 commits into from
Oct 10, 2024

Conversation

samwherever
Copy link
Contributor

@samwherever samwherever commented Oct 10, 2024 •
edited by github-actions bot
Loading

Summary

Fixes the typo as described in the issue. Sorry for the double PR on this, I had to fix something weird that was occurring.

Fixes #42882

Internal previews

📄 File 🔗 Preview link
docs/core/compatibility/9.0.md docs/core/compatibility/9.0

@samwherever samwherever requested review from gewarren and a team as code owners October 10, 2024 15:47
@dotnet-policy-service dotnet-policy-service bot added okr-quality Content-quality KR: Concerns article defects (bugs), freshness, or build warnings. community-contribution Indicates PR is created by someone from the .NET community. labels Oct 10, 2024
gewarren
gewarren approved these changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

gewarren
gewarren approved these changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked at this a little more closely. The obsoletions were introduced in multiple previews. It was probably originally supposed to be 1-6, but let's just say "multiple".

docs/core/compatibility/9.0.md Outdated Show resolved Hide resolved
@samwherever @gewarren
Update docs/core/compatibility/9.0.md
d6fc768 
Updated per @gewarren's suggestion

Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
@gewarren gewarren enabled auto-merge (squash) October 10, 2024 22:58
@gewarren gewarren merged commit 7c6e680 into dotnet:main Oct 10, 2024
8 checks passed
@samwherever samwherever deleted the sa-fix-42882 branch October 11, 2024 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sigeje sigeje sigeje approved these changes

@gewarren gewarren gewarren approved these changes

Assignees
No one assigned
Labels
community-contribution Indicates PR is created by someone from the .NET community. okr-quality Content-quality KR: Concerns article defects (bugs), freshness, or build warnings.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Breaking changes in .NET 9" has a typo for "API obsoletions with custom diagnostic IDs"
3 participants
@samwherever @sigeje @gewarren