From d6d38e405484148855192144a74024519c11b731 Mon Sep 17 00:00:00 2001
From: Elinor Fung <elfung@microsoft.com>
Date: Tue, 25 Jun 2024 05:22:12 -0700
Subject: [PATCH] Update AssesmblyBuilder.DefineDynamicModule to call out that
 .NET Core/5+ only supports one module per assembly (#10057)

* Update AssesmblyBuilder.DefineDynamicModule to call out that .NET Core/5+ only supports one module per assembly

* Update xml/System.Reflection.Emit/AssemblyBuilder.xml

Co-authored-by: Jan Kotas <jkotas@microsoft.com>

---------

Co-authored-by: Jan Kotas <jkotas@microsoft.com>
---
 xml/System.Reflection.Emit/AssemblyBuilder.xml | 16 ++++++++++++----
 1 file changed, 12 insertions(+), 4 deletions(-)

diff --git a/xml/System.Reflection.Emit/AssemblyBuilder.xml b/xml/System.Reflection.Emit/AssemblyBuilder.xml
index aeab14be3cf..c2c048fcb2c 100644
--- a/xml/System.Reflection.Emit/AssemblyBuilder.xml
+++ b/xml/System.Reflection.Emit/AssemblyBuilder.xml
@@ -576,7 +576,9 @@ The following code example shows how to define and use a dynamic assembly. The e
           <format type="text/markdown"><![CDATA[
 
 ## Remarks
- It is an error to define multiple dynamic modules with the same name in an assembly.
+.NET Core and .NET 5+ only: [Multi-module assemblies are not supported](/dotnet/core/porting/net-framework-tech-unavailable#loading-multi-module-assemblies). Only one dynamic module may be defined in an assembly.
+
+.NET Framework only: It is an error to define multiple dynamic modules with the same name in an assembly.
 
  The defined dynamic module is transient. The dynamic module is not saved, even if the parent dynamic assembly was created with <xref:System.Reflection.Emit.AssemblyBuilderAccess.RunAndSave>.
 
@@ -607,9 +609,15 @@ The following code example shows how to define and use a dynamic assembly. The e
 
  -or-
 
- The length of <paramref name="name" /> is greater than the system-defined maximum length.</exception>
+ The length of <paramref name="name" /> is greater than the system-defined maximum length.
+
+ -or-
+
+ .NET Framework only: A module with the same <paramref name="name" /> has already been defined in this assembly.
+ </exception>
         <exception cref="T:System.ArgumentNullException">
           <paramref name="name" /> is <see langword="null" />.</exception>
+        <exception cref="T:System.InvalidOperationException">.NET Core and .NET 5+ only: A dynamic module has already been defined in this assembly.</exception>
         <exception cref="T:System.Security.SecurityException">The caller does not have the required permission.</exception>
         <exception cref="T:System.ExecutionEngineException">The assembly for default symbol writer cannot be loaded.
 
@@ -916,7 +924,7 @@ The following code example shows how to define and use a dynamic assembly. The e
         <param name="name">The name of the dynamic module.</param>
         <summary>When overridden in a derived class, defines a dynamic module in this assembly.</summary>
         <returns>A <see cref="T:System.Reflection.Emit.ModuleBuilder" /> representing the defined dynamic module.</returns>
-        <remarks>.NET Core supports only one module.</remarks>
+        <remarks>.NET Core and .NET 5+ support only one module per assembly.</remarks>
       </Docs>
     </Member>
     <MemberGroup MemberName="DefineResource">
@@ -1772,7 +1780,7 @@ The following code example shows how to define and use a dynamic assembly. The e
         <param name="name">The name of the requested dynamic module.</param>
         <summary>When overridden in a derived class, returns the dynamic module with the specified name.</summary>
         <returns>A <see cref="T:System.Reflection.Emit.ModuleBuilder" /> representing the requested dynamic module.</returns>
-        <remarks>.NET Core supports only one module.</remarks>
+        <remarks>.NET Core and .NET 5+ support only one module per assembly..</remarks>
       </Docs>
     </Member>
     <Member MemberName="GetExportedTypes">