Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct docs for DbConnection.State #10509

Merged
merged 2 commits into from
Oct 9, 2024
Merged

Correct docs for DbConnection.State #10509

merged 2 commits into from
Oct 9, 2024

Conversation

roji
Copy link
Member

@roji roji commented Oct 7, 2024

Fixes #10503

@roji roji requested a review from ajcvickers as a code owner October 7, 2024 17:26
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-System.Data Data APIs (ADO.NET, XML, etc). label Oct 7, 2024
@roji roji mentioned this pull request Oct 7, 2024
Closed
@learn-build-service-prod Learn Build Service (PROD)
Copy link

Learn Build status updates of commit 271cc6d:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Data.Common/DbConnection.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

gewarren
gewarren approved these changes Oct 8, 2024
View reviewed changes
xml/System.Data.Common/DbConnection.xml Outdated Show resolved Hide resolved
@roji @gewarren
Update xml/System.Data.Common/DbConnection.xml
5896753 
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
@roji roji enabled auto-merge (squash) October 9, 2024 10:46
@learn-build-service-prod Learn Build Service (PROD)
Copy link

Learn Build status updates of commit 5896753:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Data.Common/DbConnection.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@roji roji merged commit 28b1a38 into dotnet:main Oct 9, 2024
4 checks passed
@roji roji deleted the ConnectionState branch October 9, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gewarren gewarren gewarren approved these changes

@ajcvickers ajcvickers Awaiting requested review from ajcvickers

Assignees

@roji roji

Labels
area-System.Data Data APIs (ADO.NET, XML, etc).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ConnectionState is an enum, not a string
2 participants
@roji @gewarren