Add remark about getting the thumbprint using a different algorithm #10526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-System.Security
|
Tagging subscribers to this area: @dotnet/area-system-security, @vcsjones |
|
Learn Build status updates of commit bb8b050: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
bartonjs
approved these changes
Oct 9, 2024
gewarren
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
Thumbprintproperty onX509Certificate2always uses SHA-1 as the hash algorithm. I added a remark to the property indicating that to get the thumbprint using a different algorithm, such as SHA-256, they should useGetCertHashString. It is not always obvious to some people that the thumbprint of the cert and its hash are the same thing.