Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build suggestions #10605

Merged
merged 3 commits into from
Oct 24, 2024
Merged

Fix build suggestions #10605

merged 3 commits into from
Oct 24, 2024

Conversation

gewarren
Copy link
Contributor

Contributes to dotnet/docs#41280

(Hide whitespace changes.)

@gewarren gewarren requested a review from a team as a code owner October 23, 2024 21:52
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-Meta Concerns something that extends across runtime area boundaries, for example, IDisposable. label Oct 23, 2024
Copy link
Contributor

@gewarren - This PR edits one or more files whose 'source of truth' for documentation is not in this repo. Please make documentation updates in the /// comments in the dotnet/runtime repo (or dotnet/extensions repo) instead.

This comment was marked as outdated.

This comment was marked as outdated.

Copy link

Learn Build status updates of commit 6de5993:

✅ Validation status: passed

File Status Preview URL Details
xml/Microsoft.Extensions.ObjectPool/ObjectPool.xml ✅Succeeded View
xml/System.Collections.Generic/IDictionary`2.xml ✅Succeeded View
xml/System.ComponentModel.Design/ObjectSelectorEditor.xml ✅Succeeded View
xml/System.Numerics.Tensors/Tensor.xml ✅Succeeded View
xml/System.Numerics.Tensors/TensorPrimitives.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM @gewarren

Let's :shipit:

@gewarren gewarren merged commit 36097ee into dotnet:main Oct 24, 2024
4 checks passed
@gewarren gewarren deleted the sugg102324 branch October 24, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Meta Concerns something that extends across runtime area boundaries, for example, IDisposable.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants