Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI Update - SourceLink config for Windows Forms #10686

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Conversation

gewarren
Copy link
Contributor

Build.Reason:Manual by Genevieve Warren
Build.Url:https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=477391&view=results
source_repo.branch:wf-config
source_repo.url:https://apidrop.visualstudio.com/_git/binaries

Summary

Added implementation package as a dependent package, since those assemblies have the debug info and the ref package doesn't.

 Build.Reason:Manual by Genevieve Warren
 Build.Url:https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=477391&view=results
 source_repo.branch:wf-config
 source_repo.url:https://apidrop.visualstudio.com/_git/binaries
Copy link
Contributor

@gewarren - This PR edits one or more files whose 'source of truth' for documentation is not in this repo. Please make documentation updates in the /// comments in the dotnet/runtime repo (or dotnet/extensions repo) instead.

@gewarren gewarren enabled auto-merge (squash) November 15, 2024 00:08
Copy link

Learn Build status updates of commit 92f599f:

✅ Validation status: passed

File Status Preview URL Details
xml/Microsoft.Extensions.Caching.Hybrid/HybridCache.xml ✅Succeeded View
xml/Microsoft.Extensions.DependencyInjection.Extensions/ServiceCollectionDescriptorExtensions.xml ✅Succeeded View
xml/Microsoft.Extensions.Diagnostics.Metrics/MetricsBuilderExtensions.xml ✅Succeeded View
xml/SourceLinkInformation/windowsdesktop-7.0/Microsoft.VisualBasic.Forms.json ✅Succeeded
xml/SourceLinkInformation/windowsdesktop-7.0/Microsoft.Win32.Registry.AccessControl.json ✅Succeeded
xml/SourceLinkInformation/windowsdesktop-7.0/Microsoft.Win32.SystemEvents.json ✅Succeeded
xml/SourceLinkInformation/windowsdesktop-7.0/System.CodeDom.json ✅Succeeded
xml/SourceLinkInformation/windowsdesktop-7.0/System.Configuration.ConfigurationManager.json ✅Succeeded
xml/SourceLinkInformation/windowsdesktop-7.0/System.Diagnostics.EventLog.json ✅Succeeded
xml/SourceLinkInformation/windowsdesktop-7.0/System.Diagnostics.PerformanceCounter.json ✅Succeeded
xml/SourceLinkInformation/windowsdesktop-7.0/System.DirectoryServices.json ✅Succeeded
xml/SourceLinkInformation/windowsdesktop-7.0/System.Drawing.Common.json ✅Succeeded
xml/SourceLinkInformation/windowsdesktop-7.0/System.IO.Packaging.json ✅Succeeded
xml/SourceLinkInformation/windowsdesktop-7.0/System.Resources.Extensions.json ✅Succeeded
xml/SourceLinkInformation/windowsdesktop-7.0/System.Security.Cryptography.Pkcs.json ✅Succeeded
xml/SourceLinkInformation/windowsdesktop-7.0/System.Security.Cryptography.ProtectedData.json ✅Succeeded
xml/SourceLinkInformation/windowsdesktop-7.0/System.Security.Cryptography.Xml.json ✅Succeeded
xml/SourceLinkInformation/windowsdesktop-7.0/System.Security.Permissions.json ✅Succeeded
xml/SourceLinkInformation/windowsdesktop-7.0/System.Threading.AccessControl.json ✅Succeeded
xml/SourceLinkInformation/windowsdesktop-7.0/System.Windows.Extensions.json ✅Succeeded
xml/SourceLinkInformation/windowsdesktop-7.0/System.Windows.Forms.Design.json ✅Succeeded
xml/SourceLinkInformation/windowsdesktop-7.0/System.Windows.Forms.json ✅Succeeded
xml/SourceLinkInformation/windowsdesktop-7.0/System.Windows.Forms.Primitives.json ✅Succeeded
xml/SourceLinkInformation/windowsdesktop-8.0/Microsoft.VisualBasic.Forms.json ✅Succeeded
xml/SourceLinkInformation/windowsdesktop-8.0/Microsoft.Win32.Registry.AccessControl.json ✅Succeeded

This comment lists only the first 25 files in the pull request.
For more details, please refer to the build report.

For any questions, please:

Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM @gewarren

Let's :shipit:

@gewarren gewarren merged commit 591c1d5 into main Nov 15, 2024
4 checks passed
@gewarren gewarren deleted the wf-sourcelink branch November 15, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants