Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving details from blog post #10821

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

ManickaP
Copy link
Member

@ManickaP ManickaP commented Jan 8, 2025

Added notes to remarks for SP and SPM properties about their behavior on modern .NET.

Ready for review.

Use "Hide whitespace changes" for comparison.

@ManickaP ManickaP marked this pull request as ready for review January 8, 2025 15:58
@ManickaP ManickaP requested a review from a team as a code owner January 8, 2025 15:58
@ManickaP ManickaP marked this pull request as draft January 8, 2025 15:58

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

@ManickaP ManickaP force-pushed the service-point branch 3 times, most recently from 49b0b82 to 84703ea Compare January 10, 2025 12:51

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

Copy link

Learn Build status updates of commit 46e5a04:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Net/ServicePoint.xml ✅Succeeded View
xml/System.Net/ServicePointManager.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@ManickaP ManickaP marked this pull request as ready for review January 10, 2025 16:10
@ManickaP ManickaP changed the title [DRAFT] Moving details from blog post Moving details from blog post Jan 10, 2025
Some load balancing techniques require a client to use a specific local IP address and port number, rather than <xref:System.Net.IPAddress.Any?displayProperty=nameWithType> (or <xref:System.Net.IPAddress.IPv6Any?displayProperty=nameWithType> for Internet Protocol Version 6) and an ephemeral port. Your <xref:System.Net.ServicePoint.BindIPEndPointDelegate> can satisfy this requirement.

> [!NOTE]
> On modern .NET, <xref:System.Net.HttpWebRequest> uses <xref:System.Net.Http.SocketsHttpHandler.ConnectCallback?displayProperty=nameWithType> to bind the underlying socket to the endpoint from this delegate.
Copy link
Member

@antonfirsov antonfirsov Jan 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

modern .NET

I don't see us using this term anywhere else in the API docs. Moreover, these properties are unimplemented on .NET 8, which is still LTS. I would prefer being specific here and define the expected behavior per-version.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of these were implemented in the past, some of them are there from the very beginning of .NET Core, some have been implemented this latest release. For that reason I chose the cop out of "Modern .NET" here. As figuring out what exact version to use for each of these is gonna be quite time consuming.
I can do that if you think it's worth the effort, but I don't really want to 🥲

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gewarren any general guidelines about the terminlogy and the level of detail we should use here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with Anton. "Modern .NET" doesn't provide clarity and will almost certainly lead to negative feedback for confused customers. Also, 10 years from now, the versions you're referring to won't be considered "modern .NET". Do you want me to try and help figure out the versions?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As another cop out, I can just put .NET 9 everywhere. It's not wrong info, just in some cases it might be working for older versions as well.

Do you want me to try and help figure out the versions?

Feel free to try, but just FYI, it's not about looking at the property itself, but at its usages in different classes (mainly HttpWebRequest AFAIK) and seeing if it's used in way that it will affect something.

Copy link
Member

@antonfirsov antonfirsov Jan 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine using the term .NET 9+ everywhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants