-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moving details from blog post #10821
base: main
Are you sure you want to change the base?
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
234df8c
to
03244cc
Compare
This comment was marked as outdated.
This comment was marked as outdated.
03244cc
to
5009a1f
Compare
This comment was marked as outdated.
This comment was marked as outdated.
5009a1f
to
236ab87
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
49b0b82
to
84703ea
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
84703ea
to
a609f60
Compare
This comment was marked as outdated.
This comment was marked as outdated.
a609f60
to
d26b397
Compare
This comment was marked as outdated.
This comment was marked as outdated.
d26b397
to
c3c37da
Compare
This comment was marked as outdated.
This comment was marked as outdated.
c3c37da
to
46bba4e
Compare
46bba4e
to
46e5a04
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Learn Build status updates of commit 46e5a04: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Some load balancing techniques require a client to use a specific local IP address and port number, rather than <xref:System.Net.IPAddress.Any?displayProperty=nameWithType> (or <xref:System.Net.IPAddress.IPv6Any?displayProperty=nameWithType> for Internet Protocol Version 6) and an ephemeral port. Your <xref:System.Net.ServicePoint.BindIPEndPointDelegate> can satisfy this requirement. | ||
|
||
> [!NOTE] | ||
> On modern .NET, <xref:System.Net.HttpWebRequest> uses <xref:System.Net.Http.SocketsHttpHandler.ConnectCallback?displayProperty=nameWithType> to bind the underlying socket to the endpoint from this delegate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
modern .NET
I don't see us using this term anywhere else in the API docs. Moreover, these properties are unimplemented on .NET 8, which is still LTS. I would prefer being specific here and define the expected behavior per-version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of these were implemented in the past, some of them are there from the very beginning of .NET Core, some have been implemented this latest release. For that reason I chose the cop out of "Modern .NET" here. As figuring out what exact version to use for each of these is gonna be quite time consuming.
I can do that if you think it's worth the effort, but I don't really want to 🥲
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gewarren any general guidelines about the terminlogy and the level of detail we should use here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with Anton. "Modern .NET" doesn't provide clarity and will almost certainly lead to negative feedback for confused customers. Also, 10 years from now, the versions you're referring to won't be considered "modern .NET". Do you want me to try and help figure out the versions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As another cop out, I can just put .NET 9 everywhere. It's not wrong info, just in some cases it might be working for older versions as well.
Do you want me to try and help figure out the versions?
Feel free to try, but just FYI, it's not about looking at the property itself, but at its usages in different classes (mainly HttpWebRequest
AFAIK) and seeing if it's used in way that it will affect something.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine using the term .NET 9+ everywhere.
Added notes to remarks for SP and SPM properties about their behavior on modern .NET.
Ready for review.
Use "Hide whitespace changes" for comparison.