Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config files are .NET Framework only (System.Diagnostics) #7979

Merged
merged 2 commits into from
Apr 21, 2022

Conversation

gewarren
Copy link
Contributor

@gewarren gewarren commented Apr 20, 2022

This PR annotates remarks that refer to settings in application configuration files as being specific to .NET Framework.

Contributes to #7970.

Hide whitespace changes in diff.

@ghost
Copy link

ghost commented Apr 20, 2022

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

Issue Details

This PR annotates remarks that refer to settings in application configuration files as being specific to .NET Framework.

Hide whitespace changes in diff.

Author: gewarren
Assignees: -
Labels:

area-System.Diagnostics

Milestone: -

@opbld30
Copy link

opbld30 commented Apr 21, 2022

Docs Build status updates of commit d09a2f3:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Diagnostics/BooleanSwitch.xml ✅Succeeded View
xml/System.Diagnostics/ConsoleTraceListener.xml ✅Succeeded View
xml/System.Diagnostics/Debug.xml ✅Succeeded View
xml/System.Diagnostics/DefaultTraceListener.xml ✅Succeeded View
xml/System.Diagnostics/DelimitedListTraceListener.xml ✅Succeeded View
xml/System.Diagnostics/EventLogTraceListener.xml ✅Succeeded View
xml/System.Diagnostics/EventSchemaTraceListener.xml ✅Succeeded View
xml/System.Diagnostics/EventTypeFilter.xml ✅Succeeded View
xml/System.Diagnostics/PresentationTraceSources.xml ✅Succeeded View
xml/System.Diagnostics/SourceSwitch.xml ✅Succeeded View
xml/System.Diagnostics/Switch.xml ✅Succeeded View
xml/System.Diagnostics/TextWriterTraceListener.xml ✅Succeeded View
xml/System.Diagnostics/Trace.xml ✅Succeeded View
xml/System.Diagnostics/TraceLevel.xml ✅Succeeded View
xml/System.Diagnostics/TraceOptions.xml ✅Succeeded View
xml/System.Diagnostics/TraceSource.xml ✅Succeeded View
xml/System.Diagnostics/TraceSwitch.xml ✅Succeeded View
xml/System.Diagnostics/XmlWriterTraceListener.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM @gewarren

You can :shipit: when ready.

@gewarren gewarren merged commit 8ef9638 into dotnet:main Apr 21, 2022
@gewarren gewarren deleted the System.Diagnostics-config branch April 21, 2022 16:31
@gewarren
Copy link
Contributor Author

Thanks @BillWagner!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants