Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge main into live #9401

Merged
merged 4 commits into from
Oct 24, 2023
Merged

Merge main into live #9401

merged 4 commits into from
Oct 24, 2023

Conversation

ghost
Copy link

@ghost ghost commented Oct 24, 2023

Please don't squash-merge this PR.

Rageking8 and others added 4 commits October 23, 2023 07:03
* Add example for optional attr

* Fix up space issues

Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
Build.Reason:Manual by Min Huang
 Build.Url:https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=393037&view=results
 source_repo.branch:master
 source_repo.url:https://apidrop.visualstudio.com/_git/binaries

Co-authored-by: VSC-Service-Account <vscavu@microsoft.com>
@learn-build-service-prod
Copy link

Learn Build status updates of commit 8a1b0a0:

⚠️ Validation status: warnings

File Status Preview URL Details
xml/System.ServiceModel.Channels/HttpRequestMessageProperty.xml ⚠️Warning View Details
xml/System.ServiceModel.Channels/HttpResponseMessageProperty.xml ⚠️Warning View Details
snippets/csharp/System.Runtime.InteropServices/OptionalAttribute/Overview/Project.csproj ✅Succeeded
snippets/csharp/System.Runtime.InteropServices/OptionalAttribute/Overview/sample.cs ✅Succeeded View
xml/Microsoft.Extensions.Configuration/ConfigurationManager.xml ✅Succeeded View
xml/Microsoft.Extensions.DependencyInjection/OptionsBuilderExtensions.xml ✅Succeeded View
xml/Microsoft.Extensions.DependencyInjection/ServiceCollection.xml ✅Succeeded View
xml/Microsoft.Extensions.Hosting/SystemdHostBuilderExtensions.xml ✅Succeeded View
xml/Microsoft.Extensions.Hosting/WindowsServiceLifetimeHostBuilderExtensions.xml ✅Succeeded View
xml/Microsoft.Extensions.Logging/ILoggingBuilder.xml ✅Succeeded View
xml/Microsoft.Extensions.Primitives/InplaceStringBuilder.xml ✅Succeeded View
xml/Microsoft.JScript/JScriptException.xml ✅Succeeded View
xml/Microsoft.Win32.SafeHandles/SafeNCryptHandle.xml ✅Succeeded View
xml/Microsoft.Win32.SafeHandles/SafeNCryptKeyHandle.xml ✅Succeeded View
xml/Microsoft.Win32.SafeHandles/SafeNCryptProviderHandle.xml ✅Succeeded View
xml/Microsoft.Win32.SafeHandles/SafeNCryptSecretHandle.xml ✅Succeeded View
xml/Microsoft.Win32.SafeHandles/SafeRegistryHandle.xml ✅Succeeded View
xml/Microsoft.Win32.SafeHandles/SafeX509ChainHandle.xml ✅Succeeded View
xml/Microsoft.Win32/FileDialog.xml ✅Succeeded View
xml/ns-System.Collections.Immutable.xml ✅Succeeded View
xml/System.Buffers.Text/Base64.xml ✅Succeeded View
xml/System.Collections.Generic/KeyedByTypeCollection`1.xml ✅Succeeded View
xml/System.Collections.Generic/SynchronizedCollection`1.xml ✅Succeeded View
xml/System.ComponentModel.DataAnnotations/AssociatedMetadataTypeTypeDescriptionProvider.xml ✅Succeeded View
xml/System.ComponentModel.DataAnnotations/MetadataTypeAttribute.xml ✅Succeeded View

This comment lists only the first 25 files in the pull request.

xml/System.ServiceModel.Channels/HttpRequestMessageProperty.xml

  • Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'System.ServiceModel.Channels.IMergeEnabledMessageProperty'.

xml/System.ServiceModel.Channels/HttpResponseMessageProperty.xml

  • Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'System.ServiceModel.Channels.IMergeEnabledMessageProperty'.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@BillWagner BillWagner merged commit bd34165 into live Oct 24, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants