Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing Meter Docs #9415

Merged
merged 5 commits into from
Oct 28, 2023
Merged

Add missing Meter Docs #9415

merged 5 commits into from
Oct 28, 2023

Conversation

tarekgh
Copy link
Member

@tarekgh tarekgh commented Oct 27, 2023

No description provided.

@tarekgh tarekgh requested a review from a team as a code owner October 27, 2023 17:44
@ghost ghost assigned tarekgh Oct 27, 2023
@ghost
Copy link

ghost commented Oct 27, 2023

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: tarekgh
Assignees: tarekgh
Labels:

area-System.Diagnostics

Milestone: -

@tarekgh
Copy link
Member Author

tarekgh commented Oct 27, 2023

CC @carlossanlop @gewarren

@learn-build-service-prod
Copy link

Learn Build status updates of commit 9d1a352:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Diagnostics.Metrics/IMeterFactory.xml ✅Succeeded View
xml/System.Diagnostics.Metrics/Instrument.xml ✅Succeeded View
xml/System.Diagnostics.Metrics/Instrument`1.xml ✅Succeeded View
xml/System.Diagnostics.Metrics/Meter.xml ✅Succeeded View
xml/System.Diagnostics.Metrics/MeterFactoryExtensions.xml ✅Succeeded View
xml/System.Diagnostics.Metrics/MeterOptions.xml ✅Succeeded View
xml/System.Diagnostics.Metrics/ObservableInstrument`1.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link
Member

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 75%. Left some suggestions.

xml/System.Diagnostics.Metrics/IMeterFactory.xml Outdated Show resolved Hide resolved
xml/System.Diagnostics.Metrics/Instrument.xml Outdated Show resolved Hide resolved
xml/System.Diagnostics.Metrics/Instrument`1.xml Outdated Show resolved Hide resolved
xml/System.Diagnostics.Metrics/Meter.xml Outdated Show resolved Hide resolved
xml/System.Diagnostics.Metrics/Meter.xml Outdated Show resolved Hide resolved
xml/System.Diagnostics.Metrics/Meter.xml Outdated Show resolved Hide resolved
xml/System.Diagnostics.Metrics/Meter.xml Outdated Show resolved Hide resolved
xml/System.Diagnostics.Metrics/Meter.xml Outdated Show resolved Hide resolved
xml/System.Diagnostics.Metrics/Meter.xml Outdated Show resolved Hide resolved
xml/System.Diagnostics.Metrics/Meter.xml Outdated Show resolved Hide resolved
Copy link
Member

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest of them.

xml/System.Diagnostics.Metrics/ObservableInstrument`1.xml Outdated Show resolved Hide resolved
xml/System.Diagnostics.Metrics/ObservableInstrument`1.xml Outdated Show resolved Hide resolved
xml/System.Diagnostics.Metrics/MeterOptions.xml Outdated Show resolved Hide resolved
xml/System.Diagnostics.Metrics/Instrument.xml Outdated Show resolved Hide resolved
xml/System.Diagnostics.Metrics/Instrument`1.xml Outdated Show resolved Hide resolved
Co-authored-by: Carlos Sánchez López <1175054+carlossanlop@users.noreply.github.com>
@learn-build-service-prod
Copy link

Learn Build status updates of commit e023381:

❌ Validation status: errors

Please follow instructions here which may help to resolve issue.

File Status Preview URL Details
❌Error Details
xml/System.Diagnostics.Metrics/Instrument`1.xml ❌Error Details

  • Line 0, Column 0: [Error: ECMA2Yaml_File_LoadFailed] Failed to load 1 files, aborting...

xml/System.Diagnostics.Metrics/Instrument`1.xml

  • Line 0, Column 0: [Error: ECMA2Yaml_InternalError]
Intenal Several Error: System.Xml.XmlException: 'T' is an unexpected token. Expecting whitespace. Line 143, position 52.
   at System.Xml.XmlTextReaderImpl.Throw(Exception e)
   at System.Xml.XmlTextReaderImpl.Throw(String res, String arg)
   at System.Xml.XmlTextReaderImpl.ThrowExpectingWhitespace(Int32 pos)
   at System.Xml.XmlTextReaderImpl.ParseAttributes()
   at System.Xml.XmlTextReaderImpl.ParseElement()
   at System.Xml.XmlTextReaderImpl.ParseElementContent()
   at System.Xml.Linq.XContainer.ReadContentFrom(XmlReader r)
   at System.Xml.Linq.XDocument.Load(XmlReader reader, LoadOptions options)
   at System.Xml.Linq.XDocument.Parse(String text, LoadOptions options)
   at ECMA2Yaml.ECMALoader.LoadType(FileItem typeFile)
   at ECMA2Yaml.ECMALoader.LoadTypes(String basePath, Namespace ns)

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@learn-build-service-prod
Copy link

Learn Build status updates of commit ad32746:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Diagnostics.Metrics/IMeterFactory.xml ✅Succeeded View
xml/System.Diagnostics.Metrics/Instrument.xml ✅Succeeded View
xml/System.Diagnostics.Metrics/Instrument`1.xml ✅Succeeded View
xml/System.Diagnostics.Metrics/Meter.xml ✅Succeeded View
xml/System.Diagnostics.Metrics/MeterFactoryExtensions.xml ✅Succeeded View
xml/System.Diagnostics.Metrics/MeterOptions.xml ✅Succeeded View
xml/System.Diagnostics.Metrics/ObservableInstrument`1.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@learn-build-service-prod
Copy link

Learn Build status updates of commit ae90263:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Diagnostics.Metrics/IMeterFactory.xml ✅Succeeded View
xml/System.Diagnostics.Metrics/Instrument.xml ✅Succeeded View
xml/System.Diagnostics.Metrics/Instrument`1.xml ✅Succeeded View
xml/System.Diagnostics.Metrics/Meter.xml ✅Succeeded View
xml/System.Diagnostics.Metrics/MeterFactoryExtensions.xml ✅Succeeded View
xml/System.Diagnostics.Metrics/MeterOptions.xml ✅Succeeded View
xml/System.Diagnostics.Metrics/ObservableInstrument`1.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

xml/System.Diagnostics.Metrics/Instrument.xml Outdated Show resolved Hide resolved
xml/System.Diagnostics.Metrics/Instrument.xml Outdated Show resolved Hide resolved
xml/System.Diagnostics.Metrics/Instrument.xml Outdated Show resolved Hide resolved
xml/System.Diagnostics.Metrics/Instrument`1.xml Outdated Show resolved Hide resolved
xml/System.Diagnostics.Metrics/Instrument`1.xml Outdated Show resolved Hide resolved
xml/System.Diagnostics.Metrics/Instrument`1.xml Outdated Show resolved Hide resolved
xml/System.Diagnostics.Metrics/Instrument`1.xml Outdated Show resolved Hide resolved
xml/System.Diagnostics.Metrics/ObservableInstrument`1.xml Outdated Show resolved Hide resolved
xml/System.Diagnostics.Metrics/ObservableInstrument`1.xml Outdated Show resolved Hide resolved
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
@learn-build-service-prod
Copy link

Learn Build status updates of commit b7c8bdf:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Diagnostics.Metrics/IMeterFactory.xml ✅Succeeded View
xml/System.Diagnostics.Metrics/Instrument.xml ✅Succeeded View
xml/System.Diagnostics.Metrics/Instrument`1.xml ✅Succeeded View
xml/System.Diagnostics.Metrics/Meter.xml ✅Succeeded View
xml/System.Diagnostics.Metrics/MeterFactoryExtensions.xml ✅Succeeded View
xml/System.Diagnostics.Metrics/MeterOptions.xml ✅Succeeded View
xml/System.Diagnostics.Metrics/ObservableInstrument`1.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@tarekgh tarekgh merged commit 0f5ffa4 into main Oct 28, 2023
2 checks passed
@tarekgh tarekgh deleted the AddMissingMeterDocs branch October 28, 2023 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants