Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require code in internal API for logging Warns/Errors #11087

Closed
JanKrivanek opened this issue Dec 5, 2024 · 2 comments
Closed

Require code in internal API for logging Warns/Errors #11087

JanKrivanek opened this issue Dec 5, 2024 · 2 comments
Labels

Comments

@JanKrivanek
Copy link
Member

Context

Suggested by @Nirmal4G here #10388 (comment)

With Code specified in the targets, we can just do a text search on a preprocessed file, and we can go to that exact line. This saves a ton of time combing through binlog or imported files.

And if you want to indicate the Code mapping in RESX, why not add it in the comments? There's a reason that previous text only message tasks had a separate Code parameter instead of just putting them in the Text parameter.

@JanKrivanek
Copy link
Member Author

Team triage: not meeting the bar for investment

@Nirmal4G
Copy link
Contributor

Nirmal4G commented Jan 8, 2025

Okay. "Investment" is a big word for such a simple refactor of an API where any other team is yet to consume.

As I said before, the benefits outweigh the maintenance cost if any already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants