Remove source-only package #11006
Merged
Remove source-only package #11006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryzngard
approved these changes
Oct 11, 2024
Comment on lines
+18
to
+21
| if (callback is null) | ||
| { | ||
| throw new ArgumentNullException(nameof(callback)); | ||
| } |
There was a problem hiding this comment.
nit: we have nullable analysis so we don't need to do null checks
Suggested change
| if (callback is null) | |
| { | |
| throw new ArgumentNullException(nameof(callback)); | |
| } |
There was a problem hiding this comment.
True, but I'm not sure it's a good idea to modify the copied source very much in case we want to update it from the upstream later.
davidwengier
approved these changes
Oct 11, 2024
There was a problem hiding this comment.
I thought our CI should have caught these types of things :(
There was a problem hiding this comment.
I think it was disabled before
<!--
The NonCapturingTimer package is a source package, and the source files in there don't conform to our header
poilcy, so we have to ignore that error code for this project.
-->
<NoWarn>$(NoWarn);IDE0073</NoWarn>
There was a problem hiding this comment.
Oh, derp, yep. I missed that entirely.
This was referenced Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted out of #11000.