Skip to content

Commit

Permalink
Remove dynamic load of QueryDebugger (#1968)
Browse files Browse the repository at this point in the history
  • Loading branch information
idg10 authored Jun 14, 2023
1 parent f4f727c commit 95d9ea9
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 21 deletions.
6 changes: 5 additions & 1 deletion Rx.NET/Documentation/ReleaseHistory/Rx.v6.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
# Rx Release History v6.0

## v6.0.0-preview
## v6.0.1-preview

This release fixes [Issue #1942: "AOT compilation produces single trim analysis warning"](https://github.com/dotnet/reactive/issues/1942)

## v6.0.0

### Breaking changes

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -68,27 +68,9 @@ public class CurrentPlatformEnlightenmentProvider : IPlatformEnlightenmentProvid
// expectation it'd be pretty hard to turn on interception dynamically
// upon a debugger attach event, so we should make this check early.
//
// In the initial release of v2.0 (RTM), we won't have the corresponding
// debugger assembly available yet, so the dynamic load would always
// fail. We also don't want to take the price of (an attempt to) a dynamic
// assembly load for the regular production case.
//
if (Debugger.IsAttached)
{
var ifType = t.GetTypeInfo();

var asm = new AssemblyName(ifType.Assembly.FullName!)
{
Name = "System.Reactive"
};

var name = "System.Reactive.Linq.QueryDebugger, " + asm.FullName;

var dbg = Type.GetType(name, false);
if (dbg != null)
{
return (T?)Activator.CreateInstance(dbg);
}
return (T)(object)new QueryDebugger();
}
}

Expand Down
2 changes: 1 addition & 1 deletion Rx.NET/Source/version.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"version": "6.0.0-preview.{height}",
"version": "6.0.1-preview.{height}",
"publicReleaseRefSpec": [
"^refs/heads/main$", // we release out of main
"^refs/heads/rel/v\\d+\\.\\d+", // we also release branches starting with rel/vN.N
Expand Down

0 comments on commit 95d9ea9

Please sign in to comment.