Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change merge conflict resolution instructions #887

Open
JoeRobich opened this issue Jan 29, 2021 · 1 comment
Open

Change merge conflict resolution instructions #887

JoeRobich opened this issue Jan 29, 2021 · 1 comment

Comments

@JoeRobich
Copy link
Member

JoeRobich commented Jan 29, 2021

The steps for resolving merge conflicts locally for a merge PR read as follows.

git fetch --all
git checkout merges/master-to-master-vs-deps
git reset --hard upstream/master-vs-deps
git merge upstream/master
# Fix merge conflicts
git commit
git push upstream merges/master-to-master-vs-deps --force

Since the merge branch points to upstream/master, the step to reset the branch to upstream/master-vs-deps shows a big change in merges (obviously) and requires the use of a force push. I believe it would be simpler and provide a more expected experience to leave the branch pointing to upstream/master and to merge upstream/master-vs-deps into the merge branch.

These are the proposed instructions

git fetch upstream
git checkout merges/master-to-master-vs-deps
# Pull in latest changes
git reset --hard upstream/master 
git merge upstream/master-vs-deps
# Fix merge conflicts with `git mergetool` or by other means
git commit
git push upstream merges/master-to-master-vs-deps
@RikkiGibson
Copy link
Contributor

I'm fine with this. I'd also consider changing the first line to git fetch upstream master master-vs-deps, and deleting and recreating the merges/* branch. But I'm particularly sensitive to the time needed to fetch everything, especially since I have 18 remotes in my local repo 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants