Enhance dotnet-roslyn prfinder to support AzDO repos. #1191
Conversation
JoeRobich
commented
Mar 25, 2022
JoeRobich
commented
- Removes old PRFinder project
- Moves PRFinder to use libgit2sharp
- Determine repo Url from repo remotes
- Process GitHub and AzDO repos differently
|
Joey, you're a wizard.. |
| public FileContainerHttpClient ContainerClient { get; } | ||
| public ProjectHttpClient ProjectClient { get; } | ||
|
|
||
| public AzDOConnection(string azdoUrl, string projectName, SecretClient client, string secretName) | ||
| public AzDOConnection(string azdoUrl, string projectName, string buildDefinitionName, SecretClient client, string secretName) |
There was a problem hiding this comment.
I hate buildDefinitionName 😋
There was a problem hiding this comment.
Yeah, I dunno if BuildDefinition is an old TFS-ism or not. BuildPipelineName or PipelineName are likely more meaningful to us. CreateTags uses it and I wanted to unify the AzDOConnection classes. Happy to take changes in a follow up.
There was a problem hiding this comment.
Yeah, I also wanted to unify the AzDOConnection classes in #1189 but the build pipeline name is just annoying, because its AzDo project specific, and product specific. Will update that PR now that this is merged though, and see where we land.
There was a problem hiding this comment.
The real funs begins when we move RIT to be part of dotnet-roslyn (#1168)
