Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider move length-based string dispatch behind /optimize #69674

Closed
sharwell opened this issue Aug 23, 2023 · 1 comment · Fixed by #70680
Closed

Consider move length-based string dispatch behind /optimize #69674

sharwell opened this issue Aug 23, 2023 · 1 comment · Fixed by #70680
Assignees
@jcouv
Labels
4 - In Review A fix for the issue is submitted for review. Area-Compilers Feature Request
Milestone
17.9

Comments

@sharwell
Copy link
Member

sharwell commented Aug 23, 2023 •
edited
Loading

This is a request to only enable the optimization from #66081 when /optimize flag is provided. Based on observations in AB#1874059, this feature can be costly, and it may be good to avoid it in common IDE/debugging scenarios.

Additional work to improve the compile-time performance of the optimization is submitted in #69673.
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Aug 23, 2023
@sharwell sharwell changed the title Move length-based string dispatch behind /optimize Consider move length-based string dispatch behind /optimize Aug 23, 2023
@jcouv jcouv self-assigned this Oct 11, 2023
@jcouv jcouv added this to the 17.9 milestone Oct 11, 2023
@jcouv jcouv added Feature Request and removed untriaged Issues and PRs which have not yet been triaged by a lead labels Oct 11, 2023
@jcouv
Copy link
Member

jcouv commented Oct 11, 2023

@jaredpar I'll plan to do this in 17.9. Let me know if you have any concerns

@jcouv jcouv added the help wanted The issue is "up for grabs" - add a comment if you are interested in working on it label Oct 11, 2023
@jcouv jcouv removed the help wanted The issue is "up for grabs" - add a comment if you are interested in working on it label Oct 30, 2023
@jcouv jcouv mentioned this issue Nov 2, 2023
Merged
@jcouv jcouv added the 4 - In Review A fix for the issue is submitted for review. label Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jcouv jcouv

Labels
4 - In Review A fix for the issue is submitted for review. Area-Compilers Feature Request
Projects
None yet
Milestone
17.9
Development

Successfully merging a pull request may close this issue.

Only use length-based dispatch optimization under /optimize+ jcouv/roslyn
3 participants
@jasonmalinowski @sharwell @jcouv