Avoid substring allocation in Environment.ReadXdgDirectory (#103765)

* Avoid substring allocation in Environment.ReadXdgDirectory * Update src/libraries/System.Private.CoreLib/src/System/Environment.GetFolderPathCore.Unix.cs Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com> --------- Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>
dotnet · Jun 21, 2024 · 66cffdf · 66cffdf
1 parent fc70f8b
commit 66cffdf
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/src/libraries/System.Private.CoreLib/src/System/Environment.GetFolderPathCore.Unix.cs b/src/libraries/System.Private.CoreLib/src/System/Environment.GetFolderPathCore.Unix.cs
@@ -228,11 +228,10 @@ private static string ReadXdgDirectory(string homeDir, string key, string fallba
                             int endPos = line.IndexOf('"', pos);
                             if (endPos <= pos) continue;
 
-                            // Got we need.  Now extract it.
-                            string path = line.Substring(pos, endPos - pos);
+                            // Got what we need.  Now extract it.
                             return relativeToHome ?
-                                Path.Combine(homeDir, path) :
-                                path;
+                                Path.Join(homeDir, line.AsSpan(pos, endPos - pos)) :
+                                line.Substring(pos, endPos - pos);
                         }
                     }
                 }