Skip to content

Commit

Permalink
[iOS] Skip test suites that take too long to build on helix (#72849)
Browse files Browse the repository at this point in the history
System.Text.RegularExpressions, Microsoft.Extensions.Logging.Generators.Roslyn4.0.Tests, and STJ source generator tests take too long to build on helix and time out before any tests are run. This is due in part to the amount of aot'd code, which ends up ballooning the app size to around 1GB.  The solution is to enable aggressive trimming targets that are in tests.mobile.targets as this will shrink the app size considerably.

Skipping these tests for now.

Addresses #72834

Addresses #72836
  • Loading branch information
steveisok authored Jul 27, 2022
1 parent fbced1b commit c421a7c
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion src/libraries/tests.proj
Original file line number Diff line number Diff line change
Expand Up @@ -286,11 +286,16 @@
<!--
Test apps that are too large and take too long to build
Keep here until aggressive trimming targets can work on helix.
https://github.com/dotnet/runtime/issues/72834
https://github.com/dotnet/runtime/issues/72836
-->
<ProjectExclusions Include="$(MSBuildThisFileDirectory)System.Text.RegularExpressions\tests\UnitTests\System.Text.RegularExpressions.Tests.csproj" />
<ProjectExclusions Include="$(MSBuildThisFileDirectory)System.Text.RegularExpressions\tests\FunctionalTests\System.Text.RegularExpressions.Tests.csproj" />
<ProjectExclusions Include="$(MSBuildThisFileDirectory)Microsoft.Extensions.Logging.Abstractions\tests\Microsoft.Extensions.Logging.Generators.Tests\Microsoft.Extensions.Logging.Generators.Roslyn4.0.Tests.csproj" />
<ProjectExclusions Include="$(MSBuildThisFileDirectory)System.Text.Json\tests\System.Text.Json.SourceGeneration.Unit.Tests\System.Text.Json.SourceGeneration.Roslyn4.0.Unit.Tests.csproj" />
<ProjectExclusions Include="$(MSBuildThisFileDirectory)System.Text.Json\tests\System.Text.Json.SourceGeneration.Tests\System.Text.Json.SourceGeneration.Roslyn4.0.Tests.csproj" />


<!-- Functional tests on devices have problems with return codes from mlaunch -->
<ProjectExclusions Include="$(RepoRoot)\src\tests\FunctionalTests\$(TargetOS)\Device\**\*.Test.csproj" />
</ItemGroup>
Expand Down

0 comments on commit c421a7c

Please sign in to comment.