-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix relocs errors on riscv64 #111317
base: main
Are you sure you want to change the base?
Fix relocs errors on riscv64 #111317
Conversation
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas |
src/coreclr/tools/aot/ILCompiler.Compiler/Compiler/ObjectWriter/ElfObjectWriter.cs
Outdated
Show resolved
Hide resolved
2dd124f
to
afa2118
Compare
src/coreclr/tools/Common/Compiler/DependencyAnalysis/Relocation.cs
Outdated
Show resolved
Hide resolved
src/coreclr/tools/Common/Compiler/DependencyAnalysis/Relocation.cs
Outdated
Show resolved
Hide resolved
…n.cs Co-authored-by: Tomasz Sowiński <tomeksowi@gmail.com>
src/coreclr/tools/Common/Compiler/DependencyAnalysis/Relocation.cs
Outdated
Show resolved
Hide resolved
src/coreclr/tools/Common/Compiler/DependencyAnalysis/Relocation.cs
Outdated
Show resolved
Hide resolved
src/coreclr/tools/Common/Compiler/DependencyAnalysis/Relocation.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Tomek Sowiński <tomeksowi@gmail.com>
Co-authored-by: Filip Navara <filip.navara@gmail.com>
@dotnet/samsung with these patches, succeeds. Execution throws SIGILL. With the default linker (
Overall it's a progress. We can take this in and continue hackathon in the tracking issue. PTAL. |
Thanks. They are handled the same way in ILC as well, only distinguishing themselves at the JIT interface level. I can remove it if the separate identity is not desired. |
This ignores the emitter assertion in AOT mode seen here #106223 (comment). Also, missed JALR encoding/decoding in the previous PR. With these changes, the ilc is compiling all the methods and creating object file without errors.