Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide Dictionary<T, V> to native implemented, because we found the iterator so slower than python #43756

Closed
srxqds opened this issue Oct 23, 2020 · 4 comments
Labels
api-suggestion Early API idea and discussion, it is NOT ready for implementation area-Codegen-Interpreter-mono untriaged New issue has not been triaged by the area owner

Comments

@srxqds
Copy link
Contributor

srxqds commented Oct 23, 2020

as these issues show:
#43720
#42426

the dictionary iterator so slower, I think it is better to provider native implemented of List and Dictionary, like Array.

@srxqds srxqds added the api-suggestion Early API idea and discussion, it is NOT ready for implementation label Oct 23, 2020
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added area-System.Collections untriaged New issue has not been triaged by the area owner labels Oct 23, 2020
@ghost
Copy link

ghost commented Oct 23, 2020

Tagging subscribers to this area: @eiriktsarpalis, @jeffhandley
See info in area-owners.md if you want to be subscribed.

@ghost
Copy link

ghost commented Oct 23, 2020

Tagging subscribers to this area: @BrzVlad
See info in area-owners.md if you want to be subscribed.

@BrzVlad
Copy link
Member

BrzVlad commented Oct 23, 2020

The fact that the interpreter is currently slow on these method is not enough of a reason to change the whole bcl implementation. Will keep an eye on tests from #42426, for future interp optimizations

@BrzVlad BrzVlad closed this as completed Oct 23, 2020
@srxqds
Copy link
Contributor Author

srxqds commented Oct 23, 2020

ok, thank you.
but you can provide the native dicionary like py_dict other than replace dictionary.

@ghost ghost locked as resolved and limited conversation to collaborators Dec 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api-suggestion Early API idea and discussion, it is NOT ready for implementation area-Codegen-Interpreter-mono untriaged New issue has not been triaged by the area owner
Projects
None yet
Development

No branches or pull requests

4 participants