[Android][arm64] Use of undeclared identifier 'ICALL_SIG_TYPE__Bool' #91779
Comments
simonrozsival
added
arch-arm64
blocking-clean-ci
|
Tagging subscribers to 'arch-android': @steveisok, @akoeplinger Issue DetailsBuild InformationBuild: https://dev.azure.com/dnceng-public/cbb18261-c48f-4abb-8651-8cdcb5474649/_build/results?buildId=399447 Android arm64 builds are failing (x64 and arm builds don't seem to be affected) with the following error: Error Message{
"ErrorMessage": "(NETCORE_ENGINEERING_TELEMETRY=Build) The command " cmake --build . --target install --config Release --parallel 4" exited with code 2.",
"BuildRetry": false,
"ExcludeConsoleLog": false
}
|
|
Related to the C11 changes recently probably |
|
We shouldn't use the bareword |
ghost
added
the
in-pr
|
This should be resolved, waiting for a green build to close it. There will be a follow-up to reintroduce the changes that were reverted. |
It will expand to `_Bool` in C11 and mess things up. Use `boolean` instead Fixes dotnet#91779
ghost
locked as resolved and limited conversation to collaborators
* For each platform decide if we will use C11 standard atomics, Win32 API atomics, GCC atomic intrinsics or emulated atomics. To use C11 atomics we generally want them to be lock-free for the primitive types we care about (that is, `ATOMIC_LONG_LONG_LOCK_FREE == 2` not `1` and similarly for other macros) because otherwise we cannot be sure if the atomic might use a global lock in which case we could have thread suspend problems if both the GC and the rest of the runtime use an atomic at the same time. * On win32, use the win32 atomics until MSVC atomics support is not experimental, or we update our build to pass `/experimental:c11atomics`; and also until we build our C++ code with C++23 or later (otherwise MSVC will complain about including stdatomic.h) * If the header gets included while we're generating offsets using `offsets-tool.py`, pretend we're using emulated atomics. On some Linux configurations, the libclang that we use ends up picking up the platform `atomic.h` header, not the clang one, and then errors out on their underlying implementation. * Replace the use of `bool` in some macros in Mono - it will expand to `_Bool` in C11 and mess things up. Use `boolean` instead Fixes #91779
ghost
removed
the
in-pr
Build Information
Build: https://dev.azure.com/dnceng-public/cbb18261-c48f-4abb-8651-8cdcb5474649/_build/results?buildId=399447
Build error leg or test failing: Build / android-arm64 Release AllSubsets_Mono / Build product
Pull request: #91520
Android arm64 builds are failing (x64 and arm builds don't seem to be affected) with the following error:
Known Issue Error Message
Fill the error message using step by step known issues guidance.
{ "ErrorMessage": "(NETCORE_ENGINEERING_TELEMETRY=Build) The command \" cmake --build . --target install --config Release --parallel 4\" exited with code 2.", "ErrorPattern": "", "BuildRetry": false, "ExcludeConsoleLog": false }Known issue validation
Build: 🔎 https://dev.azure.com/dnceng-public/public/_build/results?buildId=399447
Error message validated:
(NETCORE_ENGINEERING_TELEMETRY=Build) The command " cmake --build . --target install --config Release --parallel 4" exited with code 2.Result validation: ✅ Known issue matched with the provided build.
Validation performed at: 9/8/2023 8:20:10 AM UTC
Report
Summary
The text was updated successfully, but these errors were encountered: