Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wasm] MeterDisposeTest is failing #93754

Open
lewing opened this issue Oct 19, 2023 · 4 comments
Open

[wasm] MeterDisposeTest is failing #93754

lewing opened this issue Oct 19, 2023 · 4 comments
Labels
arch-wasm WebAssembly architecture area-Codegen-Interpreter-mono disabled-test The test is disabled in source code against the issue
Milestone
10.0.0

Comments

@lewing
Copy link
Member

lewing commented Oct 19, 2023

Starting in #93337 MeterDisposeTest started failing on wasm

[13:39:53] info: [2023-10-19T13:39:53.690Z] [FAIL] Microsoft.Extensions.Diagnostics.Metrics.Tests.DefaultMetricsFactoryTests.MeterDisposeTest
[13:39:53] info: Assert.Equal() Failure: Values differ
[13:39:53] info: Expected: 10
[13:39:53] info: Actual:   0
[13:39:53] info:    at Microsoft.Extensions.Diagnostics.Metrics.Tests.DefaultMetricsFactoryTests.MeterDisposeTest()
[13:39:53] info:    at System.Reflection.MethodBaseInvoker.InterpretedInvoke_Method(Object obj, IntPtr* args)
[13:39:53] info:    at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)
@ghost ghost added the untriaged New issue has not been triaged by the area owner label Oct 19, 2023
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Oct 19, 2023
@danmoseley danmoseley added arch-wasm WebAssembly architecture area-Codegen-Interpreter-mono and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Oct 20, 2023
@ghost
Copy link

ghost commented Oct 20, 2023

Tagging subscribers to this area: @BrzVlad, @kotlarmilos
See info in area-owners.md if you want to be subscribed.

Issue Details

Starting in #93337 MeterDisposeTest started failing on wasm

[13:39:53] info: [2023-10-19T13:39:53.690Z] [FAIL] Microsoft.Extensions.Diagnostics.Metrics.Tests.DefaultMetricsFactoryTests.MeterDisposeTest
[13:39:53] info: Assert.Equal() Failure: Values differ
[13:39:53] info: Expected: 10
[13:39:53] info: Actual:   0
[13:39:53] info:    at Microsoft.Extensions.Diagnostics.Metrics.Tests.DefaultMetricsFactoryTests.MeterDisposeTest()
[13:39:53] info:    at System.Reflection.MethodBaseInvoker.InterpretedInvoke_Method(Object obj, IntPtr* args)
[13:39:53] info:    at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)
Author: lewing
Assignees: -
Labels:

arch-wasm, untriaged, area-Codegen-Interpreter-mono
Milestone: -

@SamMonoRT SamMonoRT added this to the 9.0.0 milestone Oct 27, 2023
@ghost ghost removed the untriaged New issue has not been triaged by the area owner label Oct 27, 2023
@SamMonoRT SamMonoRT added the disabled-test The test is disabled in source code against the issue label Oct 27, 2023
@SamMonoRT
Copy link
Member

@lewing @radical - I'm not sure who the right owner is, but I assigned @radical for tracking. Reach out to Vlad if indeed an interpreter issue (I don't think it is though). I also added disabled-test label, and removed the untriaged label, setting it to 9.0.0

@radical radical removed their assignment Mar 21, 2024
@lewing lewing modified the milestones: 9.0.0, 10.0.0 Jul 30, 2024
@lewing
Copy link
Member Author

lewing commented Jul 30, 2024

@mkhamoyan please check if the test is still failing and update the status here

@mkhamoyan
Copy link
Contributor

@lewing I have checked, and the test is still failing.

@mkhamoyan mkhamoyan removed their assignment Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
arch-wasm WebAssembly architecture area-Codegen-Interpreter-mono disabled-test The test is disabled in source code against the issue
Projects
None yet
Milestone
10.0.0
Development

No branches or pull requests
5 participants
@radical @lewing @danmoseley @SamMonoRT @mkhamoyan