From 012883510fdbe1c940ebfab2518ebf5e933f495f Mon Sep 17 00:00:00 2001 From: Ahmet Ibrahim Aksoy Date: Tue, 16 Apr 2024 11:01:25 +0200 Subject: [PATCH 1/2] Disable SocketsHttpHandler_HttpClientHandler_MaxResponseHeadersLength_Http3 test suite --- .../Http/HttpClientHandlerTest.MaxResponseHeadersLength.cs | 6 ------ .../tests/FunctionalTests/SocketsHttpHandlerTest.cs | 2 ++ 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.MaxResponseHeadersLength.cs b/src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.MaxResponseHeadersLength.cs index d9be1bdf931f0..0fe06a4670ef9 100644 --- a/src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.MaxResponseHeadersLength.cs +++ b/src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.MaxResponseHeadersLength.cs @@ -73,12 +73,6 @@ await LoopbackServerFactory.CreateClientAndServerAsync(async uri => [InlineData(15)] public async Task LargeSingleHeader_ThrowsException(int maxResponseHeadersLength) { - if (UseVersion == HttpVersion30) - { - // [ActiveIssue("https://github.com/dotnet/runtime/issues/94507")] - return; - } - using HttpClientHandler handler = CreateHttpClientHandler(); handler.MaxResponseHeadersLength = maxResponseHeadersLength; diff --git a/src/libraries/System.Net.Http/tests/FunctionalTests/SocketsHttpHandlerTest.cs b/src/libraries/System.Net.Http/tests/FunctionalTests/SocketsHttpHandlerTest.cs index d2e1b54dcafa8..5a7c80894bd35 100644 --- a/src/libraries/System.Net.Http/tests/FunctionalTests/SocketsHttpHandlerTest.cs +++ b/src/libraries/System.Net.Http/tests/FunctionalTests/SocketsHttpHandlerTest.cs @@ -1634,6 +1634,8 @@ public SocketsHttpHandler_HttpClientHandler_MaxResponseHeadersLength_Http2(ITest } [ConditionalClass(typeof(HttpClientHandlerTestBase), nameof(IsQuicSupported))] + [ActiveIssue("https://github.com/dotnet/runtime/issues/94507")] + [ActiveIssue("https://github.com/dotnet/runtime/issues/101015")] public sealed class SocketsHttpHandler_HttpClientHandler_MaxResponseHeadersLength_Http3 : SocketsHttpHandler_HttpClientHandler_MaxResponseHeadersLength { public SocketsHttpHandler_HttpClientHandler_MaxResponseHeadersLength_Http3(ITestOutputHelper output) : base(output) { } From b861b4c8d61407abd050dd6c929aae8ec63cb186 Mon Sep 17 00:00:00 2001 From: Ahmet Ibrahim Aksoy Date: Tue, 16 Apr 2024 13:11:04 +0200 Subject: [PATCH 2/2] Update src/libraries/System.Net.Http/tests/FunctionalTests/SocketsHttpHandlerTest.cs Co-authored-by: Miha Zupan --- .../tests/FunctionalTests/SocketsHttpHandlerTest.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libraries/System.Net.Http/tests/FunctionalTests/SocketsHttpHandlerTest.cs b/src/libraries/System.Net.Http/tests/FunctionalTests/SocketsHttpHandlerTest.cs index 5a7c80894bd35..72d6090165de5 100644 --- a/src/libraries/System.Net.Http/tests/FunctionalTests/SocketsHttpHandlerTest.cs +++ b/src/libraries/System.Net.Http/tests/FunctionalTests/SocketsHttpHandlerTest.cs @@ -1634,7 +1634,7 @@ public SocketsHttpHandler_HttpClientHandler_MaxResponseHeadersLength_Http2(ITest } [ConditionalClass(typeof(HttpClientHandlerTestBase), nameof(IsQuicSupported))] - [ActiveIssue("https://github.com/dotnet/runtime/issues/94507")] + [ActiveIssue("https://github.com/dotnet/runtime/issues/91757")] [ActiveIssue("https://github.com/dotnet/runtime/issues/101015")] public sealed class SocketsHttpHandler_HttpClientHandler_MaxResponseHeadersLength_Http3 : SocketsHttpHandler_HttpClientHandler_MaxResponseHeadersLength {