Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RedHat 7 -> 8 -- release/6.0-staging #105063

Merged

Conversation

richlander
Copy link
Member

@richlander richlander commented Jul 18, 2024

Red Hat no longer supports .NET 6 on RHEL 7.

Context: https://access.redhat.com/support/policy/updates/net-core

Also resolving #103380 (comment)

@omajid @akoeplinger

Copy link
Member

@omajid omajid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know the format of these files too well, but the general change from 7 to 8 makes sense to me.

@am11 am11 added area-Infrastructure and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Jul 19, 2024
Copy link
Contributor

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

@carlossanlop
Copy link
Member

No equivalent PR for release/8.0-staging?

Copy link
Member

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@richlander this is failing:

.packages/microsoft.dotnet.helix.sdk/6.0.0-beta.24360.7/tools/Microsoft.DotNet.Helix.Sdk.MonoQueue.targets(59,5): error : (NETCORE_ENGINEERING_TELEMETRY=Build) Helix API does not contain an entry for RedHat.8.Amd64.Open

Here: https://dev.azure.com/dnceng-public/public/_build/results?buildId=745875&view=logs&j=1f44e919-17d8-5098-631c-31ef11f9e57b&t=d617d884-da52-5b82-bd49-f7613b408af4&l=92

and here: https://dev.azure.com/dnceng-public/public/_build/results?buildId=745875&view=logs&j=bc8f69e2-91b3-518c-84f8-466a04c1af40&t=0864dbdb-cb3f-5f82-b0b6-057b78db53e2&l=92

@carlossanlop carlossanlop self-requested a review August 14, 2024 21:12
@carlossanlop carlossanlop added the Servicing-approved Approved for servicing release label Aug 14, 2024
@carlossanlop
Copy link
Member

Approving for servicing as tell-mode. You can merge anytime if the CI looks good.

@richlander
Copy link
Member Author

Silly me. I didn't realize that we didn't have a RHEL 8 queue. Tracking issue: dotnet/dnceng#3867.

I also didn't realize that they list was available: https://helix.dot.net/

@carlossanlop
Copy link
Member

@richlander any updates on this? Is it ready to merge?

@richlander
Copy link
Member Author

Thanks for checking in. The tracking issue is still open.

@carlossanlop
Copy link
Member

BTW friendly reminder: Code Complete for the October Release is September 9. If we want this fix to be included in that release, please merge this PR before that date. Otherwise, it will have to wait until November.

@carlossanlop carlossanlop removed the Servicing-approved Approved for servicing release label Sep 19, 2024
@carlossanlop
Copy link
Member

Removing servicing-approved to prevent accidental merge. @richlander feel free to add the label again when you're ready to merge (it will unblock the check-service-labels required CI leg).

@carlossanlop
Copy link
Member

carlossanlop commented Oct 1, 2024

@richlander we are going to need this PR merged soon as all existing PRs in the release/6.0-staging are now failing with the following error:

❌SENDHELIXJOB(0,0): error : Helix queue redhat.7.amd64.open is set for estimated removal date of 2024-10-01. 
In most cases the queue will be removed permanently due to end-of-life; please contact dnceng for any questions 
or concerns, and we can help you decide how to proceed and discuss other options.

Examples:

https://github.com/dotnet/runtime/pull/108300/checks?check_run_id=30735541280 , https://github.com/dotnet/runtime/pull/107828/checks?check_run_id=30735326967 , https://github.com/dotnet/runtime/pull/107826/checks?check_run_id=30735395206 , https://github.com/dotnet/runtime/pull/107764/checks?check_run_id=30735049259

@carlossanlop carlossanlop added blocking Marks issues that we want to fast track in order to unblock other important work blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' labels Oct 1, 2024
@richlander
Copy link
Member Author

I'll raise this with the right folks.

@richlander
Copy link
Member Author

My thinking is:

  • Replace RHEL7 with CentOS 7 to preserve validating min glibc.
  • Add CentOS Stream 9 for outer loop testing.

@carlossanlop
Copy link
Member

/ba-g The wasm "connection refused" and "Chrome was unable to start" failures that did not get linked to an issue are unrelated to this PR. One of them is #104349

@carlossanlop carlossanlop added the Servicing-approved Approved for servicing release label Oct 3, 2024
@carlossanlop carlossanlop added this to the 6.0.36 milestone Oct 3, 2024
@carlossanlop carlossanlop merged commit 8b6500b into dotnet:release/6.0-staging Oct 3, 2024
115 of 126 checks passed
@richlander richlander deleted the release/6.0-staging-eol branch October 16, 2024 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Infrastructure blocking Marks issues that we want to fast track in order to unblock other important work blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' Servicing-approved Approved for servicing release
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants