[browser][MT] add missing core assemblies #105244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelsavara
added
arch-wasm
|
Tagging subscribers to 'arch-wasm': @lewing |
pavelsavara
commented
Jul 22, 2024
| @@ -18,7 +18,11 @@ public class BootJsonBuilderHelper(TaskLoggingHelper Log, string DebugLevel, boo | |||
| ]; | |||
|
|
|||
| private static readonly string[] extraMultiThreadedCoreAssemblyName = [ | |||
| "System.Threading.Channels" | |||
| "System.Threading.Channels", | |||
There was a problem hiding this comment.
We have unit test failing with Could not load file or assembly System.Threading when the timing of the downloads is in favorable order.
I'm not sure if I need to really provide all dependencies of System.Threading.Channels but I do it just to be on the safe side.
maraf
approved these changes
Jul 22, 2024
This was referenced Jul 22, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #102749