Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[browser][MT] add missing core assemblies #105244

Merged
merged 1 commit into from
Jul 22, 2024
Merged

[browser][MT] add missing core assemblies #105244

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/tasks/Microsoft.NET.Sdk.WebAssembly.Pack.Tasks/BootJsonBuilderHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,11 @@ public class BootJsonBuilderHelper(TaskLoggingHelper Log, string DebugLevel, boo
];

private static readonly string[] extraMultiThreadedCoreAssemblyName = [
"System.Threading.Channels"
"System.Threading.Channels",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have unit test failing with Could not load file or assembly System.Threading when the timing of the downloads is in favorable order.

I'm not sure if I need to really provide all dependencies of System.Threading.Channels but I do it just to be on the safe side.

"System.Threading.ThreadPool",
"System.Threading",
"System.Collections",
"System.Collections.Concurrent",
];

public bool IsCoreAssembly(string fileName)
Expand Down
Loading