Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark Encoding as nullable in StreamWriter's constructor #106658

Merged
merged 6 commits into from
Sep 16, 2024
Merged

Mark Encoding as nullable in StreamWriter's constructor #106658

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
05b383a
Mark Encoding as nullable in StreamWriter's constructor
stefannikolei Aug 19, 2024
a3f1176
Update reference file
stefannikolei Aug 21, 2024
af15dbd
Align string constructors with Stream
stefannikolei Aug 21, 2024
02542f8
Merge branch 'main' into streamwriter_constructor
stefannikolei Aug 31, 2024
4591bff
add explicit test for null as encoding
stefannikolei Sep 3, 2024
0f4d86a
Merge branch 'main' into streamwriter_constructor
stefannikolei Sep 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/libraries/System.Private.CoreLib/src/System/IO/StreamWriter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ public StreamWriter(Stream stream)
{
}

public StreamWriter(Stream stream, Encoding encoding)
public StreamWriter(Stream stream, Encoding? encoding)
: this(stream, encoding, DefaultBufferSize, false)
{
}
Expand All @@ -86,7 +86,7 @@ public StreamWriter(Stream stream, Encoding encoding)
// character encoding is set by encoding and the buffer size,
// in number of 16-bit characters, is set by bufferSize.
//
public StreamWriter(Stream stream, Encoding encoding, int bufferSize)
public StreamWriter(Stream stream, Encoding? encoding, int bufferSize)
: this(stream, encoding, bufferSize, false)
{
}
Expand Down
Loading