-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/9.0] TypeName fuzzer and bug fixes #107533
Conversation
* add initial AssemblyNameInfo Fuzzer * fix the first bug that it has discovered
Co-authored-by: Miha Zupan <mihazupan.zupan1@gmail.com> Co-authored-by: Adam Sitnik <adam.sitnik@gmail.com>
@MihuBot fuzz TypeName |
@MihuBot fuzz AssemblyNameInfo |
I added support to the bot for running against non-main base branches now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@artl93 - Please review this for RC2 inclusion
This PR combines the PRs that added Fuzzing for both
TypeName
andAssemblyNameInfo
with the most recent bug fixes.Once it gets merged there won't be known bugs related to
TypeName
andAssemblyNameInfo
parsing inrelease/9.0
Fuzzing PR:
Backport of #107195 to release/9.0 (it has also contained empty name fix)
Backport of #107257 to release/9.0
Backport of #107206 to release/9.0
Bug fixes:
Backport of #106334 to release/9.0
Backport of #107261 to release/9.0
/cc @jkotas @buyaa-n
Customer Impact
Two bugs were found by the Fuzzer (
sbyte
overflow and incorrect handling of empty assembly names), the last one was reported internally by @jkotas.Regression
[If yes, specify when the regression was introduced. Provide the PR or commit if known.]
Testing
All bugs discovered by the Fuzzer has been turned into unit tests (and of course are passing now).
Risk
Low. The bug fixes were relatively simple:
AssemblyNameInfo
parsing when provided name (span) is emptyint
tosbyte
just to pass it to actor
that accepts anint