[browser] Increase timeout and clean up after failed attempts of launching browser when testing

src/mono/wasm/Wasm.Build.Tests/BrowserRunner.cs

@@ -103,11 +103,10 @@ public async Task<string> StartServerAndGetUrlAsync(
     public async Task<IBrowser> SpawnBrowserAsync(
         string browserUrl,
         bool headless = true,
-        int timeout = 10000,
+        int timeout = 15000,
         int maxRetries = 3
     ) {
         var url = new Uri(browserUrl);
-        Playwright = await Microsoft.Playwright.Playwright.CreateAsync();
         // codespaces: ignore certificate error -> Microsoft.Playwright.PlaywrightException : net::ERR_CERT_AUTHORITY_INVALID
         string[] chromeArgs = new[] { $"--explicitly-allowed-ports={url.Port}", "--ignore-certificate-errors" };
         _testOutput.WriteLine($"Launching chrome ('{s_chromePath.Value}') via playwright with args = {string.Join(',', chromeArgs)}");
@@ -117,6 +116,7 @@ public async Task<IBrowser> SpawnBrowserAsync(
         {
             try
             {
+                Playwright = await Microsoft.Playwright.Playwright.CreateAsync();
                 Browser = await Playwright.Chromium.LaunchAsync(new BrowserTypeLaunchOptions {
                     ExecutablePath = s_chromePath.Value,
                     Headless = headless,
@@ -128,17 +128,34 @@ public async Task<IBrowser> SpawnBrowserAsync(
                     Browser = null;
                     _testOutput.WriteLine("Browser has been disconnected");
                 };
-                break;
+                return Browser!;
             }
             catch (System.TimeoutException ex)
             {
                 attempt++;
-                _testOutput.WriteLine($"Attempt {attempt} failed with TimeoutException: {ex.Message}");
+                _testOutput.WriteLine($"Attempt {attempt} failed with TimeoutException: {ex}");
+
+                try
+                {
+                    // Cleanup before retrying
+                    if (Browser != null)
+                    {
+                        await Browser.CloseAsync();
+                        Browser = null;
+                    }
+                    if (Playwright != null)
+                    {
+                        Playwright.Dispose();
+                        Playwright = null;
+                    }
+                }
+                catch(Exception cleanupException)
+                {
+                    _testOutput.WriteLine($"Attempt to clean up failed with {cleanupException}");
+                }
             }
         }
-        if (attempt == maxRetries)
-            throw new Exception($"Failed to launch browser after {maxRetries} attempts");
-        return Browser!;
+        throw new Exception($"Failed to launch browser after {maxRetries} attempts");
     }
 
     // FIXME: options