Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/9.0] Update dependencies from dotnet/emsdk #108898

Merged
merged 2 commits into from
Oct 15, 2024
Merged

[release/9.0] Update dependencies from dotnet/emsdk #108898

merged 2 commits into from
Oct 15, 2024

Conversation

dotnet-maestro[bot]
Copy link
Contributor

This pull request updates the following dependencies

From https://github.com/dotnet/emsdk

  • Subscription: f85f62c8-5e7d-4706-1003-08dcbc30275f
  • Build: 20241015.1
  • Date Produced: October 15, 2024 4:29:48 PM UTC
  • Commit: 8be5676af1ccf568b258133788a24aedd1a80994
  • Branch: refs/heads/release/9.0

@dotnet-maestro
Update dependencies from https://github.com/dotnet/emsdk build 202410…
b956dee 
…15.1

Microsoft.SourceBuild.Intermediate.emsdk , Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport
 From Version 9.0.0-rtm.24513.1 -> To Version 9.0.0-rtm.24515.1
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-codeflow for labeling automated codeflow label Oct 15, 2024
carlossanlop
carlossanlop approved these changes Oct 15, 2024
View reviewed changes
Copy link
Member

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This contains the stable branding: dotnet/emsdk@8be5676

@carlossanlop carlossanlop added the Servicing-approved Approved for servicing release label Oct 15, 2024
@carlossanlop carlossanlop mentioned this pull request Oct 15, 2024
Merged
@carlossanlop
Copy link
Member

carlossanlop commented Oct 15, 2024 •
edited
Loading

@lewing @akoeplinger @mmitche this CI error is strange. Shouldn't the "rtm" version be found by now?:

src/mono/mono.proj(0,0): error NU1603: (NETCORE_ENGINEERING_TELEMETRY=Restore) Warning As Error: .NET Runtime depends on Microsoft.NET.Runtime.Emscripten.3.1.56.Cache.linux-x64 (>= 9.0.0-rtm.24515.1) but Microsoft.NET.Runtime.Emscripten.3.1.56.Cache.linux-x64 9.0.0-rtm.24515.1 was not found. Microsoft.NET.Runtime.Emscripten.3.1.56.Cache.linux-x64 10.0.0-alpha.1.24415.4 was resolved instead.

@mmitche
Copy link
Member

mmitche commented Oct 15, 2024

This is most likely an issue with the dependency properties. Using a non-stable prop for a stable dependency.

@carlossanlop
Copy link
Member

This is most likely an issue with the dependency properties. Using a non-stable prop for a stable dependency.

@mmitche so I guess I need to ignore it temporarily? Once I update the branch of the runtime stabilizing PR, the error should go away, correct?

@mmitche
Copy link
Member

mmitche commented Oct 15, 2024

Nope. The repo needs to have a new dependency added that reflects the stable package version.

@mmitche
Copy link
Member

mmitche commented Oct 15, 2024

I'll add. @lewing can you check usages of the emsdk properties?

@carlossanlop
Copy link
Member

Nope. The repo needs to have a new dependency added that reflects the stable package version.

@mmitche sorry I don't understand this part. Can you please elaborate? Do you mean this repo, runtime, needs to have a new dependency to a stable version of emsdk?

carlossanlop
carlossanlop reviewed Oct 15, 2024
View reviewed changes
eng/Version.Details.xml
<Sha>2275bbda5e4d11dec74f13583a3e6044aa713191</Sha>
<Sha>8be5676af1ccf568b258133788a24aedd1a80994</Sha>
</Dependency>
<Dependency Name="Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100" Version="9.0.0">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one's identical to the dependency above except for the version value and the *.Transport suffix. Why?

carlossanlop
carlossanlop reviewed Oct 15, 2024
View reviewed changes
eng/Versions.props
<MicrosoftNETRuntimeEmscriptenVersion>$(MicrosoftNETWorkloadEmscriptenCurrentManifest90100TransportVersion)</MicrosoftNETRuntimeEmscriptenVersion>
<MicrosoftNETWorkloadEmscriptenCurrentManifest90100TransportVersion>9.0.0-rtm.24515.1</MicrosoftNETWorkloadEmscriptenCurrentManifest90100TransportVersion>
<MicrosoftNETWorkloadEmscriptenCurrentManifest90100Version>9.0.0</MicrosoftNETWorkloadEmscriptenCurrentManifest90100Version>
<MicrosoftNETRuntimeEmscriptenVersion>$(MicrosoftNETWorkloadEmscriptenCurrentManifest90100Version)</MicrosoftNETRuntimeEmscriptenVersion>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see you're now making this property depend on the non-transport one you just added.

@mmitche mmitche merged commit b8f5d25 into release/9.0 Oct 15, 2024
160 checks passed
@dotnet-maestro dotnet-maestro bot deleted the darc-release/9.0-744aa40b-b7bd-41c8-b995-7e24e4bc803c branch October 15, 2024 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlossanlop carlossanlop carlossanlop approved these changes

Assignees
No one assigned
Labels
area-codeflow for labeling automated codeflow Servicing-approved Approved for servicing release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@carlossanlop @mmitche