Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define a function prototype for YieldProcessor #109028

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jkoritzinsky
Copy link
Member

Fixes official build failures.

@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Oct 18, 2024
src/native/minipal/time.c Outdated Show resolved Hide resolved
@am11 am11 added area-PAL-coreclr and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Oct 18, 2024
@am11
Copy link
Member

am11 commented Oct 18, 2024

I think minipal deserves its own label. 🏷️

Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>
@am11
Copy link
Member

am11 commented Oct 19, 2024

It must be due to inline otherwise none of the helpers required separate prototype https://github.com/dotnet/runtime/blob/6c7ece9479c7cbb0ca6e372adf0a0154a5f0c1a0/src/native/minipal/utf8.c. We can simply drop the inline and let compiler decide (inline is just a hint and compiler can choose to ignore it if present and vice versa).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants