Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RyuJIT] Intrinsify Object.MemberwiseClone() #46243

Merged
merged 1 commit into from
Dec 27, 2020

Conversation

EgorBo
Copy link
Member

@EgorBo EgorBo commented Dec 19, 2020

Addresses #45311 (comment)

Total bytes of delta: -2419 (-0.00% of base)
    diff is an improvement.

Top file improvements (bytes):
       -1754 : System.Private.Xml.dasm (-0.05% of base)
        -434 : System.Private.CoreLib.dasm (-0.01% of base)
        -131 : Microsoft.Diagnostics.Tracing.TraceEvent.dasm (-0.00% of base)
         -69 : System.Drawing.Common.dasm (-0.02% of base)
         -31 : Microsoft.CodeAnalysis.dasm (-0.00% of base)

5 total files with Code Size differences (5 improved, 0 regressed), 264 unchanged.

Top method improvements (bytes):
        -190 (-6.38% of base) : System.Private.Xml.dasm - Compiler:CompileElement(XmlSchemaElement):this
        -190 (-6.83% of base) : System.Private.Xml.dasm - SchemaCollectionCompiler:CompileElement(XmlSchemaElement):this
        -159 (-12.42% of base) : System.Private.Xml.dasm - XmlSchemaComplexType:Clone(XmlSchema):XmlSchemaObject:this
        -155 (-37.17% of base) : System.Private.Xml.dasm - XmlSchemaElement:Clone(XmlSchema):XmlSchemaObject:this
        -124 (-55.61% of base) : System.Private.Xml.dasm - XmlSchemaAttribute:Clone():XmlSchemaObject:this
         -73 (-29.92% of base) : System.Private.Xml.dasm - XmlSchemaSimpleTypeUnion:Clone():XmlSchemaObject:this
         -62 (-53.45% of base) : System.Private.Xml.dasm - XmlSchemaSimpleTypeList:Clone():XmlSchemaObject:this
         -62 (-53.45% of base) : System.Private.Xml.dasm - XmlSchemaSimpleTypeRestriction:Clone():XmlSchemaObject:this
         -42 (-70.00% of base) : System.Private.CoreLib.dasm - Calendar:Clone():Object:this
         -42 (-70.00% of base) : System.Private.CoreLib.dasm - TextInfo:Clone():Object:this
         -39 (-45.35% of base) : System.Private.Xml.dasm - XsltOutput:CreateDerivedOutput(int):XsltOutput:this
         -38 (-67.86% of base) : System.Drawing.Common.dasm - PrinterSettings:Clone():Object:this
         -38 (-27.94% of base) : System.Private.CoreLib.dasm - Calendar:ReadOnly(Calendar):Calendar
         -38 (-64.41% of base) : System.Private.CoreLib.dasm - NumberFormatInfo:Clone():Object:this
         -38 (-26.76% of base) : System.Private.CoreLib.dasm - NumberFormatInfo:ReadOnly(NumberFormatInfo):NumberFormatInfo
         -38 (-27.94% of base) : System.Private.CoreLib.dasm - TextInfo:ReadOnly(TextInfo):TextInfo
         -38 (-67.86% of base) : System.Private.CoreLib.dasm - Encoding:Clone():Object:this
         -36 (-70.59% of base) : Microsoft.Diagnostics.Tracing.TraceEvent.dasm - CommandOptions:Clone():CommandOptions:this
         -36 (-70.59% of base) : System.Private.CoreLib.dasm - MarshalByRefObject:MemberwiseClone(bool):MarshalByRefObject:this
         -36 (-70.59% of base) : System.Private.Xml.dasm - XmlQualifiedName:Clone():XmlQualifiedName:this

Top method improvements (percentages):
         -36 (-70.59% of base) : Microsoft.Diagnostics.Tracing.TraceEvent.dasm - CommandOptions:Clone():CommandOptions:this
         -36 (-70.59% of base) : System.Private.CoreLib.dasm - MarshalByRefObject:MemberwiseClone(bool):MarshalByRefObject:this
         -36 (-70.59% of base) : System.Private.Xml.dasm - XmlQualifiedName:Clone():XmlQualifiedName:this
         -36 (-70.59% of base) : System.Private.Xml.dasm - SchemaAttDef:Clone():SchemaAttDef:this
         -36 (-70.59% of base) : System.Private.Xml.dasm - SchemaElementDecl:Clone():SchemaElementDecl:this
         -36 (-70.59% of base) : System.Private.Xml.dasm - XmlSchemaObject:Clone():XmlSchemaObject:this
         -36 (-70.59% of base) : System.Private.Xml.dasm - QilNode:ShallowClone(QilFactory):QilNode:this
         -42 (-70.00% of base) : System.Private.CoreLib.dasm - Calendar:Clone():Object:this
         -42 (-70.00% of base) : System.Private.CoreLib.dasm - TextInfo:Clone():Object:this
         -38 (-67.86% of base) : System.Drawing.Common.dasm - PrinterSettings:Clone():Object:this
         -38 (-67.86% of base) : System.Private.CoreLib.dasm - Encoding:Clone():Object:this
         -38 (-64.41% of base) : System.Private.CoreLib.dasm - NumberFormatInfo:Clone():Object:this
        -124 (-55.61% of base) : System.Private.Xml.dasm - XmlSchemaAttribute:Clone():XmlSchemaObject:this
         -22 (-55.00% of base) : System.Private.Xml.dasm - XmlReaderSettings:Clone():XmlReaderSettings:this
         -62 (-53.45% of base) : System.Private.Xml.dasm - XmlSchemaSimpleTypeList:Clone():XmlSchemaObject:this
         -62 (-53.45% of base) : System.Private.Xml.dasm - XmlSchemaSimpleTypeRestriction:Clone():XmlSchemaObject:this
         -39 (-45.35% of base) : System.Private.Xml.dasm - XsltOutput:CreateDerivedOutput(int):XsltOutput:this
         -31 (-37.80% of base) : Microsoft.CodeAnalysis.dasm - ILBuilder:GetSnapshot():ILBuilder:this
        -155 (-37.17% of base) : System.Private.Xml.dasm - XmlSchemaElement:Clone(XmlSchema):XmlSchemaObject:this
         -31 (-36.90% of base) : System.Private.Xml.dasm - QilList:ShallowClone(QilFactory):QilNode:this

/cc @AndyAyersMS

@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Dec 19, 2020
Copy link
Member

@AndyAyersMS AndyAyersMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@AndyAyersMS AndyAyersMS merged commit 86047aa into dotnet:master Dec 27, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Jan 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants