[interp] Inline more AggressiveInlining methods #48513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @BrzVlad Issue DetailsBy default, the interpreter stops inlining when encountering a call that it cannot inline or a throw. Inline the method anyway if the aggressive inlining attribute is present.
|
|
Aids with methods like https://github.com/dotnet/runtime/blob/master/src/libraries/System.Private.CoreLib/src/System/Numerics/Vector_1.cs#L839, which the interpreter wouldn't inline, even though the code for the method would be just : This makes Vector<int>.Equals twice as fast. Contributes to #47520 |
vargaz
reviewed
Feb 19, 2021
| @@ -5453,7 +5456,8 @@ generate_code (TransformData *td, MonoMethod *method, MonoMethodHeader *header, | |||
| // Inlining failed. Set the method to be executed as part of newobj instruction | |||
| newobj_fast->data [0] = get_data_item_index (td, mono_interp_get_imethod (domain, m, error)); | |||
| /* The constructor was not inlined, abort inlining of current method */ | |||
| INLINE_FAILURE; | |||
| if (inlining && !td->aggressive_inlining) | |||
| goto exit; | |||
There was a problem hiding this comment.
Might want
if (....)
INLINE_FAILURE;
vargaz
approved these changes
Feb 19, 2021
By default, the interpreter stops inlining when encountering a call that it cannot inline or a throw. Inline the method anyway if the aggressive inlining attribute is present.
BrzVlad
force-pushed
the
feature-interp-aggressive-inline
branch
from
98260b2
to
dacbb29
Compare
BrzVlad
added a commit
to BrzVlad/mono
that referenced
this pull request
Feb 26, 2021
BrzVlad
added a commit
to BrzVlad/mono
that referenced
this pull request
Mar 15, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, the interpreter stops inlining when encountering a call that it cannot inline or a throw. Inline the method anyway if the aggressive inlining attribute is present.