-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix documentation issues in recent DateTime API additions #68019
Conversation
The microseconds parameter accepts 0-999, not 0-900.
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
Tagging subscribers to this area: @dotnet/area-system-runtime Issue DetailsThe microseconds parameter accepts 0-999, not 0-900. This was likely a copy/paste mistake from nanoseconds in #67666 /cc @tarekgh @deeprobin
|
I thought it accepts 0-999 but is has only a precision of 100ns. Is using 901 throwing an exception, if yes this PR lgtm. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @deeprobin
Right, but if you supply 999us the math will round it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this fix 👍🏼.
This LGTM.
The microseconds parameter accepts 0-999, not 0-900. This was likely a copy/paste mistake from nanoseconds in #67666
/cc @tarekgh @deeprobin