[wasm][debugger] Fix tests broken on 'main' #68054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test broke because it was checking for the number of members on `System.TimeSpan`, and that changed with dotnet#67666 , which added new members like `TotalNanoseconds`. The test shouldn't depend on this number anyway, so remove that. ``` Failed DebuggerTests.MiscTests.InspectLocalsForToStringDescriptions(line: 137, col: 12, method_name: "MethodWithLocalsForToStringTest", call_other: False, invoke_async: False) [758 ms] Error Message: [ts_props] Number of fields don't match, Expected: 12, Actual: 16 Expected: True Actual: False Stack Trace: at DebuggerTests.DebuggerTestBase.CheckProps(JToken actual, Object exp_o, String label, Int32 num_fields) in /_/src/mono/wasm/debugger/DebuggerTestSuite/DebuggerTestBase.cs:line 800 at DebuggerTests.DebuggerTestBase.CompareObjectPropertiesFor(JToken locals, String name, Object o, String label, Int32 num_fields) in /_/src/mono/wasm/debugger/DebuggerTestSuite/DebuggerTestBase.cs:line 908 at DebuggerTests.MiscTests.InspectLocalsForToStringDescriptions(Int32 line, Int32 col, String method_name, Boolean call_other, Boolean invoke_async) in /_/src/mono/wasm/debugger/DebuggerTestSuite/MiscTests.cs:line 559 ```
ghost
assigned 
|
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsThis test broke because it was checking for the number of members on The test shouldn't depend on this number anyway, so remove that.
|
thaystg
approved these changes
Apr 14, 2022
lewing
approved these changes
Apr 14, 2022
| { | ||
| if (label == null) | ||
| label = name; | ||
| var props = await GetObjectOnLocals(locals, name); | ||
| try | ||
| { | ||
| if (o != null) | ||
| await CheckProps(props, o, label, num_fields); | ||
| await CheckProps(props, o, label, num_fields, skip_num_fields_check); |
There was a problem hiding this comment.
you could reflect in the test ;)
There was a problem hiding this comment.
I tried that, and it's a little messy. And the number of members being returned will also change soon (to include private ones), so I'll have to stick with this check!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test broke because it was checking for the number of members on
System.TimeSpan, and that changed with#67666 , which added new members
like
TotalNanoseconds.The test shouldn't depend on this number anyway, so remove that.