Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm][debugger] Fix tests broken on 'main' #68054

Merged
merged 1 commit into from
Apr 15, 2022
Merged

Commits on Apr 14, 2022

  1. [wasm][debugger] Fix tests broken on 'main'

    This test broke because it was checking for the number of members on
    `System.TimeSpan`, and that changed with
    dotnet#67666 , which added new members
    like `TotalNanoseconds`.
    
    The test shouldn't depend on this number anyway, so remove that.
    
    ```
      Failed DebuggerTests.MiscTests.InspectLocalsForToStringDescriptions(line: 137, col: 12, method_name: "MethodWithLocalsForToStringTest", call_other: False, invoke_async: False) [758 ms]
      Error Message:
       [ts_props] Number of fields don't match, Expected: 12, Actual: 16
    Expected: True
    Actual:   False
      Stack Trace:
         at DebuggerTests.DebuggerTestBase.CheckProps(JToken actual, Object exp_o, String label, Int32 num_fields) in /_/src/mono/wasm/debugger/DebuggerTestSuite/DebuggerTestBase.cs:line 800
       at DebuggerTests.DebuggerTestBase.CompareObjectPropertiesFor(JToken locals, String name, Object o, String label, Int32 num_fields) in /_/src/mono/wasm/debugger/DebuggerTestSuite/DebuggerTestBase.cs:line 908
       at DebuggerTests.MiscTests.InspectLocalsForToStringDescriptions(Int32 line, Int32 col, String method_name, Boolean call_other, Boolean invoke_async) in /_/src/mono/wasm/debugger/DebuggerTestSuite/MiscTests.cs:line 559
    ```
    radical committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    e87bda5 View commit details
    Browse the repository at this point in the history