[iOS] Skip test suites that take too long to build on helix #72849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries Issue DetailsSystem.Text.RegularExpressions, Microsoft.Extensions.Logging.Generators.Roslyn4.0.Tests, and STJ source generator tests take too long to build on helix and time out before any tests are run. This is due in part to the amount of aot'd code, which ends up ballooning the app size to around 1GB. The solution is to enable aggressive trimming targets that are in tests.mobile.targets as this will shrink the app size considerably. Skipping until that happens. Addresses #72834 Addresses #72836
|
steveisok
force-pushed
the
skip-ios-tests
branch
from
5c8d9e0
to
5b18f0f
Compare
akoeplinger
approved these changes
Jul 26, 2022
System.Text.RegularExpressions, Microsoft.Extensions.Logging.Generators.Roslyn4.0.Tests, and STJ source generator tests take too long to build on helix and time out before any tests are run. This is due in part to the amount of aot'd code, which ends up ballooning the app size to around 1GB. The solution is to enable aggressive trimming targets that are in tests.mobile.targets as this will shrink the app size considerably. Skipping these tests for now. Addresses dotnet#72834 Addresses dotnet#72836
steveisok
force-pushed
the
skip-ios-tests
branch
from
5b18f0f
to
30855e8
Compare
stephentoub
approved these changes
Jul 26, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
System.Text.RegularExpressions, Microsoft.Extensions.Logging.Generators.Roslyn4.0.Tests, and STJ source generator tests take too long to build on helix and time out before any tests are run. This is due in part to the amount of aot'd code, which ends up ballooning the app size to around 1GB. The solution is to enable aggressive trimming targets that are in tests.mobile.targets as this will shrink the app size considerably. Skipping until that happens.
Addresses #72834
Addresses #72836