Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf pipeline: Switch to node 14.x #74017

Merged
merged 7 commits into from
Aug 17, 2022
Merged

perf pipeline: Switch to node 14.x #74017

merged 7 commits into from
Aug 17, 2022

Commits on Aug 16, 2022

  1. perf pipeline: Switch to node 14.x

    - Switch to node 14.x instead of 18.x, because the latter doesn't seem
    to be compatible with ubuntu 18.x:
    `node: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.28' not found (required by node)`
    
    - Also, remove the existing `nodejs` package before installing a new
    one, because these machines are shared, and would get affected by
    installations performed by other runs.
    radical committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    e760a6e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    eb8f586 View commit details
    Browse the repository at this point in the history
  3. perf pipeline: correctly return exit code, so helix can pick that up …

    …and set _commandExitCode
    radical committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    c6f0914 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    afbb55d View commit details
    Browse the repository at this point in the history
  5. Change the prereqs condition so a failure needs to be explicitly marked

    This allows cases which don't care about this, to continue working,
    because they won't set `$PERF_PREREQS_INSTALL_FAILED`, and default to
    continuing with the job.
    radical committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    a7abc51 View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2022

  1. Use --user with pip install

    radical committed Aug 17, 2022
    Configuration menu
    Copy the full SHA
    5f67b6f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    80b8adf View commit details
    Browse the repository at this point in the history