-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/7.0] Update MsQuic to 2.1.1 #75479
Conversation
please let me know if you have any concerns or if you approve it for 7.0 @danmoseley |
Tagging subscribers to this area: @dotnet/ncl Issue DetailsThis is manual port of #75287 and #75380 to pick up MsQuic 2.1.1 Customer Impactas product change this impacts only Windows as we do not include MsQuic on Unix. The test only part updates Helix images so we can execute tests on various Linux distributions. Testingtesting covered by runtime tests in Risksmall
|
Approved - we already discussed offline, this brings us into a consistent state. |
FYI - removing the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
@danmoseley it is ready for your approval -- oh, you already approved it above
#75545 opened for tracking missing test. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All infra changes. LGTM.
https://helix.dot.net/api/2019-06-17/jobs/b9b3aaf6-e04e-423e-a6c0-2e1caf0798c0/workitems/System.Net.Quic.Functional.Tests/console is strange. |
all tests are clean @carlossanlop |
Approved, signed off, CI green. Ready to merge. |
This is manual port of #75287, #75291, #75380 and #75534 to pick up MsQuic 2.1.1
(fixes #75262)
Customer Impact
as product change this impacts only Windows as we do not include MsQuic on Unix.
MsQuic 2.1.1 is bug fix releases and for .NET it is mostly needed for ARM64 on Linux.
The actual impact on Windows is small and it is mostly for consistently and to stay on top of stable msquic updates.
Also we will consume bits built and signed by MsQuic on all Windows architectures now. (we used out bits for x86 & x64 before)
The test only part updates Helix images so we can execute tests on various Linux distributions.
Testing
testing covered by runtime tests in
main
branch.Risk
small