Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/7.0] Update MsQuic to 2.1.1 #75479

Merged
merged 4 commits into from
Sep 14, 2022
Merged

Conversation

wfurt
Copy link
Member

@wfurt wfurt commented Sep 12, 2022

This is manual port of #75287, #75291, #75380 and #75534 to pick up MsQuic 2.1.1
(fixes #75262)

Customer Impact

as product change this impacts only Windows as we do not include MsQuic on Unix.
MsQuic 2.1.1 is bug fix releases and for .NET it is mostly needed for ARM64 on Linux.
The actual impact on Windows is small and it is mostly for consistently and to stay on top of stable msquic updates.
Also we will consume bits built and signed by MsQuic on all Windows architectures now. (we used out bits for x86 & x64 before)

The test only part updates Helix images so we can execute tests on various Linux distributions.

Testing

testing covered by runtime tests in main branch.

Risk

small

@wfurt
Copy link
Member Author

wfurt commented Sep 12, 2022

please let me know if you have any concerns or if you approve it for 7.0 @danmoseley

@ghost
Copy link

ghost commented Sep 12, 2022

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

This is manual port of #75287 and #75380 to pick up MsQuic 2.1.1
(fixes #75262)

Customer Impact

as product change this impacts only Windows as we do not include MsQuic on Unix.
MsQuic 2.1.1 is bug fix releases and for .NET it is mostly needed for ARM64 on Linux.
The actual impact on Windows is small and it is mostly for consistently and to stay on top of stable msquic updates.
Also we will consume bits built and signed by MsQuic on all Windows architectures now. (we used out bits for x86 & x64 before)

The test only part updates Helix images so we can execute tests on various Linux distributions.

Testing

testing covered by runtime tests in main branch.

Risk

small

Author: wfurt
Assignees: -
Labels:

area-System.Net.Quic

Milestone: -

@wfurt wfurt added this to the 7.0.0 milestone Sep 12, 2022
@wfurt wfurt added the Servicing-consider Issue for next servicing release review label Sep 12, 2022
@danmoseley
Copy link
Member

Approved - we already discussed offline, this brings us into a consistent state.

eng/pipelines/libraries/helix-queues-setup.yml Outdated Show resolved Hide resolved
eng/pipelines/libraries/helix-queues-setup.yml Outdated Show resolved Hide resolved
eng/pipelines/libraries/helix-queues-setup.yml Outdated Show resolved Hide resolved
@carlossanlop carlossanlop removed the Servicing-consider Issue for next servicing release review label Sep 12, 2022
@carlossanlop
Copy link
Member

FYI - removing the servicing-consider label. The only requirements are a code review sign off ✔️, an M2 approval, ✔️, and a green CI 🔃.

Copy link
Member

@karelz karelz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From PR #75291 we are missing:

  • Lines 46 & 48 -- Debian 10 & 11 arm64 -- the lines do not exist in 7.0, that is fine, we added them later I assume
  • Line 84 - Debian.10.Amd64
  • Line 88 - Debian.10.Amd64

Addressed in follow up commit fad7d09

@carlossanlop carlossanlop changed the title [release/7.0] udpate MsQuic to 2.1.1 [release/7.0] Update MsQuic to 2.1.1 Sep 13, 2022
Copy link
Member

@karelz karelz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!
@danmoseley it is ready for your approval -- oh, you already approved it above

@karelz karelz mentioned this pull request Sep 13, 2022
26 tasks
@wfurt
Copy link
Member Author

wfurt commented Sep 13, 2022

#75545 opened for tracking missing test.

Copy link
Member

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All infra changes. LGTM.

@carlossanlop
Copy link
Member

@wfurt @karelz @rzikm can you take a look at the failures? There's one in Quic.

@wfurt
Copy link
Member Author

wfurt commented Sep 13, 2022

https://helix.dot.net/api/2019-06-17/jobs/b9b3aaf6-e04e-423e-a6c0-2e1caf0798c0/workitems/System.Net.Quic.Functional.Tests/console is strange.
No output, no crash or message about hanging test.
I don't think we have seen anything like this on main.
I will kick re-run....

@rzikm
Copy link
Member

rzikm commented Sep 13, 2022

@wfurt can you cherry-pick this change as well? so we have updated OpenSUSE as well:
#75534

@wfurt
Copy link
Member Author

wfurt commented Sep 14, 2022

all tests are clean @carlossanlop

@carlossanlop
Copy link
Member

Approved, signed off, CI green. Ready to merge. :shipit:

@carlossanlop carlossanlop merged commit adbfdfa into dotnet:release/7.0 Sep 14, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Oct 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants