[release/7.0-rc2] [Mono] Restore old code to solve the recent SpanHelpers regressions #75932
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Tagging subscribers to this area: @dotnet/area-system-memory Issue DetailsBackport of #75917 to release/7.0-rc2 /cc @radical @adamsitnik Customer ImpactTestingRiskIMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.
|
|
@adamsitnik @radical please fill out the template, add the cc @mmitche, we have one more. |
we're going to let the perf pipeline run finish first but Steve is aware of this one |
|
The helix jobs for wasm/perf finally started running after being queued up for 2hrs. Build - |
…r-75917-to-release/7.0-rc2
|
In the earlier runs 62db96b was missing because it was merged after the last changes here. New runs:
|
|
@carlossanlop How close on this are we? Can we get this in ASAP? |
I am waiting for local benchmarks run to compare the results and verify that the PR solves the regressions. According to the tool it needs two more hours. |
|
The single failure is networking, unrelated (infra, timeout): #58628 |
@adamsitnik How are we looking here? |
The results I got don't prove that all the regressions are gone: #75917 (comment) @radekdoulik has shared offline results that show that the fix actually helps. He has run the benchmarks in different way that I did, using perf pipeline developed by @radical. I leave the decision up to @radekdoulik and @radical who own WASM and have more experience in benchmarking it. |
…75917) * bring back the old code... * bring back more old code * Use an ifdef around clr code instead of a separate file * Delete SpanHelpers.Clr.cs * Remove a remaining INumber<T> helper from mono Co-authored-by: Jeff Handley <jeffhandley@users.noreply.github.com>
|
I was worried I'd get the backport merge update wrong and I did. I'm going to close this PR and do a fresh backport from #75917 now that it's merged. |
ghost
locked as resolved and limited conversation to collaborators
Backport of #75917 to release/7.0-rc2
/cc @radical @adamsitnik
Customer Impact
Fixes large performance regression #75709 in library code when running on mono (AOT, interpreter) introduced in rc1 (#74086)
Testing
Automated benchmark is running (will add results)
Risk
Medium/Low - The patch restores the previous code path for mono