-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean-up Microsoft.Win32.Registry
and remove the non-Windows code.
#77996
Conversation
Tagging subscribers to this area: @dotnet/area-microsoft-win32 Issue DetailsIn a similar vein with other Windows-exclusive libraries, this PR makes the sources of Fixes #77974
|
@marek-safar, how close are you to merging #72667? This is going to conflict. |
src/libraries/Microsoft.Win32.Registry/src/Microsoft.Win32.Registry.csproj
Show resolved
Hide resolved
Want to merge is ASAP (likely today) |
Some trivial methods with one caller were inlined.
f8e0c5b
to
43d8fef
Compare
Conflicts are resolved. |
Are any of the CI failures concerning, @teo-tsirpanis ? |
It fails with |
The error comes from this project Line 61 in db21365
|
Fixed. |
Can we merge it? It will conflict with #78558. |
SafeRegistryHandle hKey, | ||
int dwIndex, | ||
[Out] char[] lpName, | ||
ref char lpName, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For my own education, why did you change this from a char array to a ref char?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because the name is in a stackalloc
ed span (could make it a char*
, don't remember why I didn't).
Apparently, two tests are failing deterministically. Let me retry them once again. |
Test failures are due to a known issue: #78718 |
In a similar vein with other Windows-exclusive libraries, this PR makes the sources of
Microsoft.Win32.Registry
compile only on Windows, removes the non-Windows files (they just threw PNSE), merges the.Windows
source files and cleans-up some stuff.Fixes #77974