Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NativeAOT for FreeBSD #80323

Merged
merged 51 commits into from
Jan 19, 2023
Merged

NativeAOT for FreeBSD #80323

merged 51 commits into from
Jan 19, 2023

Conversation

Thefrank
Copy link
Contributor

@Thefrank Thefrank commented Jan 7, 2023

Initial NativeAOT for FreeBSD work

Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>
@Thefrank
Copy link
Contributor Author

Test failure is unrelated(?).

Side question: Will there be tags for the new SDK that is being used? the global.json lists 8.0.100-alpha.1.23061.8. It will make it easier to build a FreeBSD SDK from tags than hunting down the commits associated with each product.

@am11
Copy link
Member

am11 commented Jan 16, 2023

Test failure is unrelated(?).

Yes, it is #78454 and #73721. You can mark your PR ready for review.

Side question: Will there be tags for the new SDK that is being used? the global.json lists 8.0.100-alpha.1.23061.8. It will make it easier to build a FreeBSD SDK from tags than hunting down the commits associated with each product.

This gives us the commit info:

$ cd runtime
$ ./dotnet.sh --info

.NET SDK:
 Version:   8.0.100-alpha.1.23061.8
 Commit:    c8d103ed3c       <---------- this is SDK commit

...

Host:
  Version:      8.0.0-alpha.1.23058.2
  Architecture: arm64
  Commit:       5da4a9e919    <---------- this is Runtime commit


# extract commit in script
$ SDK_COMMIT="$(.dotnet/dotnet --info | grep -A3 'SDK:' | grep Commit | while IFS=\  read tag hash; do echo "$hash"; done)"
$ RUNTIME_COMMIT="$(.dotnet/dotnet --info | grep -A3 'Host:' | grep Commit | while IFS=\  read tag hash; do echo "$hash"; done)"

…o.cs

Co-authored-by: Robin Sue <robinsue@live.de>
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
@Thefrank Thefrank marked this pull request as ready for review January 16, 2023 21:34
@Thefrank Thefrank changed the title WIP - NativeAOT for FreeBSD NativeAOT for FreeBSD Jan 16, 2023
Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise

…o.cs

Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>
@jkotas
Copy link
Member

jkotas commented Jan 18, 2023

Need to wait for dotnet/sdk#29800 to be merged first before merging this one.

@jkotas jkotas added blocked Issue/PR is blocked on something - see comments NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) labels Jan 18, 2023
@jkotas jkotas removed NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) blocked Issue/PR is blocked on something - see comments labels Jan 19, 2023
@jkotas jkotas merged commit 70e1072 into dotnet:main Jan 19, 2023
@jkotas
Copy link
Member

jkotas commented Jan 19, 2023

Thank you!

@Thefrank Thefrank deleted the fbsdaot branch January 23, 2023 22:19
mdh1418 pushed a commit to mdh1418/runtime that referenced this pull request Jan 24, 2023
* add inotify for FreeBSD during linking

* remove FreeBSD for now

* netstandard does not understand FreeBSD

* add FreeBSD platform to HostModel Tests

* add inotify for FreeBSD during linking

* remove FreeBSD for now

* netstandard does not understand FreeBSD

* add FreeBSD platform to HostModel Tests

* Use Clang12, update LinkerArg

* WIP FreeBSD NativeAOT

* add inotify for FreeBSD during linking

* remove FreeBSD for now

* netstandard does not understand FreeBSD

* add FreeBSD platform to HostModel Tests

* WIP FreeBSD NativeAOT

* remove FreeBSD for now

* add FreeBSD platform to HostModel Tests

* Use Clang12, update LinkerArg

* Update JITTools and ObjWriter for FreeBSD-x64

* fixes for tests

* fixes for tests

* add TargetTriple for FreeBSD

* Some changes from feedback, remove out of scope

* HostModel back to netstandard2.0

* Update src/coreclr/CMakeLists.txt

* Publish crossgen2 as single-file on cross-os

* pass NativeAotSupported to MSBuild crossgen2 tasks

* Can't use NativeAOT in source build yet

Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>

* Update private string HostFxr and HostPolicy

* Fix private string HostPolicy

* Apply suggestions from code review

Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>
Co-authored-by: Michal Strehovský <MichalStrehovsky@users.noreply.github.com>
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
Co-authored-by: Robin Sue <robinsue@live.de>
@ghost ghost locked as resolved and limited conversation to collaborators Feb 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-NativeAOT-coreclr community-contribution Indicates that the PR has been added by a community member os-freebsd FreeBSD OS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants