Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report -1 for GC.GetGeneration(nongc_obj) and same for GetObjectGeneration #85017

Merged
merged 14 commits into from
Apr 23, 2023
13 changes: 12 additions & 1 deletion src/coreclr/gc/gc.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -45804,8 +45804,16 @@ unsigned int GCHeap::WhichGeneration (Object* object)
#ifdef FEATURE_BASICFREEZE
if (!((o < g_gc_highest_address) && (o >= g_gc_lowest_address)))
{
return max_generation;
return INT32_MAX;
}
#ifndef USE_REGIONS
if (GCHeap::IsInFrozenSegment (object))
{
// in case if the object belongs to an in-range frozen segment
// For regions those are never in-range.
return INT32_MAX;
}
#endif
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Maoni0 - heads up, you probably want to look at any changes that touch the GC.

I'm fine with INT32_MAX as the value that the profiling API returns back to 3rd party code in GetGenerationBounds but I leave it to you to decide if that is also an acceptable behavior for this GC code to have.

#endif //FEATURE_BASICFREEZE
gc_heap* hp = gc_heap::heap_of (o);
unsigned int g = hp->object_gennum (o);
Expand Down Expand Up @@ -48657,6 +48665,9 @@ CFinalize::UpdatePromotedGenerations (int gen, BOOL gen_0_empty_p)
int new_gen = g_theGCHeap->WhichGeneration (*po);
if (new_gen != i)
{
// We never promote objects to a non-GC heap
assert (new_gen <= max_generation);

dprintf (3, ("Moving object %p->%p from gen %d to gen %d", po, *po, i, new_gen));

if (new_gen > i)
Expand Down
3 changes: 2 additions & 1 deletion src/coreclr/gc/gcimpl.h
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,8 @@ class GCHeap : public IGCHeapInternal
//Unregister an object for finalization
void SetFinalizationRun (Object* obj);

//returns the generation number of an object (not valid during relocation)
// returns the generation number of an object (not valid during relocation) or
// INT32_MAX if the object belongs to a non-GC heap.
unsigned WhichGeneration (Object* object);
// returns TRUE is the object is ephemeral
bool IsEphemeral (Object* object);
Expand Down
3 changes: 2 additions & 1 deletion src/coreclr/gc/gcinterface.h
Original file line number Diff line number Diff line change
Expand Up @@ -722,6 +722,7 @@ class IGCHeap {

// Returns the generation in which obj is found. Also used by the VM
// in some places, in particular syncblk code.
// Returns INT32_MAX if obj belongs to a non-GC heap.
virtual unsigned WhichGeneration(Object* obj) PURE_VIRTUAL

// Returns the number of GCs that have transpired in the given generation
Expand Down Expand Up @@ -991,7 +992,7 @@ void updateGCShadow(Object** ptr, Object* val);
#define GC_CALL_INTERIOR 0x1
#define GC_CALL_PINNED 0x2

// keep in sync with GC_ALLOC_FLAGS in GC.cs
// keep in sync with GC_ALLOC_FLAGS in GC.CoreCLR.cs
enum GC_ALLOC_FLAGS
{
GC_ALLOC_NO_FLAGS = 0,
Expand Down
14 changes: 10 additions & 4 deletions src/coreclr/inc/corerror.xml
Original file line number Diff line number Diff line change
Expand Up @@ -198,8 +198,8 @@

<HRESULT NumericValue="0x80131058">
<SymbolicName>COR_E_LOADING_REFERENCE_ASSEMBLY</SymbolicName>
<Message>"Reference assemblies cannot not be loaded for execution."</Message>
<Comment> Reference assemblies cannot not be loaded for execution. </Comment>
<Message>"Reference assemblies cannot be loaded for execution."</Message>
<Comment> Reference assemblies cannot be loaded for execution </Comment>
</HRESULT>

<HRESULT NumericValue="0x8013106A">
Expand Down Expand Up @@ -1182,6 +1182,12 @@
<Comment> The runtime cannot be suspened since a suspension is already in progress. </Comment>
</HRESULT>

<HRESULT NumericValue="0x80131389">
<SymbolicName>CORPROF_E_NOT_GC_OBJECT</SymbolicName>
<Message>"This object belongs to a non-gc heap."</Message>
<Comment> This object belongs to a non-gc heap </Comment>
</HRESULT>

<HRESULT NumericValue="0x80131416">
<SymbolicName>CORSEC_E_POLICY_EXCEPTION</SymbolicName>
<Message>"PolicyException thrown."</Message>
Expand Down Expand Up @@ -1788,8 +1794,8 @@

<HRESULT NumericValue="0x80131c14">
<SymbolicName>CORDBG_E_NGEN_NOT_SUPPORTED</SymbolicName>
<Message>"NGEN must be supported to perform the requested operation."</Message>
<Comment> NGEN must be supported to perform the requested operation </Comment>
<Message>"NGEN is not supported."</Message>
<Comment> NGEN is not supported </Comment>
</HRESULT>

<HRESULT NumericValue="0x80131c15">
Expand Down
2 changes: 2 additions & 0 deletions src/coreclr/pal/prebuilt/corerror/mscorurt.rc
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,7 @@ BEGIN
MSG_FOR_URT_HR(CORPROF_E_NOT_YET_AVAILABLE) "Requested information is not yet available."
MSG_FOR_URT_HR(CORPROF_E_TYPE_IS_PARAMETERIZED) "The given type is a generic and cannot be used with this method."
MSG_FOR_URT_HR(CORPROF_E_FUNCTION_IS_PARAMETERIZED) "The given function is a generic and cannot be used with this method."
MSG_FOR_URT_HR(CORPROF_E_NOT_GC_OBJECT) "This object belongs to a non-gc heap."
MSG_FOR_URT_HR(CORSEC_E_POLICY_EXCEPTION) "PolicyException thrown."
MSG_FOR_URT_HR(CORSEC_E_MIN_GRANT_FAIL) "Failed to grant minimum permission requests."
MSG_FOR_URT_HR(CORSEC_E_NO_EXEC_PERM) "Failed to grant permission to execute."
Expand Down Expand Up @@ -288,6 +289,7 @@ BEGIN
MSG_FOR_URT_HR(CORDBG_E_MISSING_DEBUGGER_EXPORTS) "The debuggee memory space does not have the expected debugging export table."
MSG_FOR_URT_HR(CORDBG_E_DATA_TARGET_ERROR) "Failure when calling a data target method."
MSG_FOR_URT_HR(CORDBG_E_UNSUPPORTED_DELEGATE) "The delegate contains a delegate currently not supported by the API."
MSG_FOR_URT_HR(CORDBG_E_ASSEMBLY_UPDATES_APPLIED) "The operation is not supported because assembly updates have been applied."
MSG_FOR_URT_HR(PEFMT_E_64BIT) "File is PE32+."
MSG_FOR_URT_HR(PEFMT_E_32BIT) "File is PE32"
MSG_FOR_URT_HR(CLR_E_BIND_ASSEMBLY_VERSION_TOO_LOW) "The bound assembly has a version that is lower than that of the request."
Expand Down
1 change: 1 addition & 0 deletions src/coreclr/pal/prebuilt/inc/corerror.h
Original file line number Diff line number Diff line change
Expand Up @@ -214,6 +214,7 @@
#define CORDIAGIPC_E_UNKNOWN_MAGIC EMAKEHR(0x1386)
#define CORDIAGIPC_E_UNKNOWN_ERROR EMAKEHR(0x1387)
#define CORPROF_E_SUSPENSION_IN_PROGRESS EMAKEHR(0x1388)
#define CORPROF_E_NOT_GC_OBJECT EMAKEHR(0x1389)
#define CORSEC_E_POLICY_EXCEPTION EMAKEHR(0x1416)
#define CORSEC_E_MIN_GRANT_FAIL EMAKEHR(0x1417)
#define CORSEC_E_NO_EXEC_PERM EMAKEHR(0x1418)
Expand Down
9 changes: 9 additions & 0 deletions src/coreclr/vm/proftoeeinterfaceimpl.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -9141,6 +9141,15 @@ HRESULT ProfToEEInterfaceImpl::GetObjectGeneration(ObjectID objectId,

IGCHeap *hp = GCHeapUtilities::GetGCHeap();

if (hp->IsInFrozenSegment((Object*)objectId))
{
range->generation = (COR_PRF_GC_GENERATION)INT32_MAX;
range->rangeStart = 0;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can return memory range for the given frozen segments here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can return memory range for the given frozen segments here.

I agree, but I thought that the idea was to not provide support for apis with explicit GC prefix/name/suffix for nongc objects (cc @noahfalk)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, the plan of record is to avoid treating Non-GC objects as if they are on the GC heap, and that also included not treating the non-GC segments as if they are some type of special GC generation. We could smuggle the range here at the cost of blurring the lines and potentially creating some confusion. If profiler vendors said it would be specifically helpful to them I don't think it bends the rules too badly though. From the limited profiler feedback I've heard so far folks wanted to enumerate the Non-GC region boundaries directly and resolve the pointers themsevles offline.

I'm expecting @davmason to broadcast the changes we are doing to profiler vendors and then depending on their feedback we can make adjustments.

range->rangeLength = 0;
range->rangeLengthReserved = 0;
return CORPROF_E_NOT_GC_OBJECT;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Returning error here makes this more breaking than necessary. Why can't we just return S_OK?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Returning -1 seemed like it was going to be a breaking change no matter what so I figured we may as well make it more obvious rather than try to minimize it and increase risk that tools break more subtly. However we don't yet have feedback from profiler authors one way or another and this behavior is just a best guess on my part. If you think we'd be better off defaulting to keeping S_OK @jkotas I don't have a strong opinion on it.

Copy link
Member

@VSadov VSadov Apr 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Traditionally (in textbook sense) GC generations imply that genX can be collected without collecting generations X+.

-1 makes impression that any level of GC will collect frozen, while in fact it is the opposite - any generation can be collected without touching frozen.

That seems to imply that frozen objects logically belong to generation > MAX_GEN.
Perhaps 3 or MAXINT could work better that -1 ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you think we'd be better off defaulting to keeping S_OK

It looks odd to me to return failure error code and still try to return meaningful values. I see that there are other profiler APIs that work like that, so it should be fine to return error code. You can ignore my feedback.

Copy link
Member Author

@EgorBo EgorBo Apr 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I kind of agree with @VSadov that e.g. INT_MAX value would be safer, e.g. I already had to apply a hack in code because GC/VM usages of WhichGeneration participate in comparisons so -1 will trigger a different path than previously max_generation did. Although, this is a part of the plan to make this breaking change more visible so 🤷

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps 3 or MAXINT could work better that -1

I have no particular preference between MAXINT and -1. I don't anticipate its going to make a difference myself but I also have no concern changing it. 3 I would not use - in the right context 3 is used as a legitimate generation number and the goal is that nobody should treat this value as if it is a generation.

Copy link
Member

@VSadov VSadov Apr 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are not that many purposes for WhichGeneration other than to answer questions like “can this object be collected before that one?” or “will this object survive GC X?”.

Assigning immortal objects to gen -1 feels like not the most convenient/intuitive.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried INT_MAX and there was only one place that I had to change (some NativeAOT test expecting frozen objects to be in Gen2). Also, GC.Collect(GC.GetGeneration.. is not breaking now as Jan highlighted.
For -1 it becomes a little bit more complicated.

So any strong opinions for keeping -1 ?

Copy link
Member

@VSadov VSadov Apr 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think INT_MAX is the correct value. Even with unforeseen future changes, I do not see anything collecting less often than frozen.

}

uint8_t* pStart;
uint8_t* pAllocated;
uint8_t* pReserved;
Expand Down
1 change: 1 addition & 0 deletions src/coreclr/vm/threads.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -5533,6 +5533,7 @@ void ThreadStore::TriggerGCForDeadThreadsIfNecessary()
}

unsigned exposedObjectGeneration = gcHeap->WhichGeneration(exposedObject);
_ASSERTE(exposedObjectGeneration != INT32_MAX);
SIZE_T newDeadThreadGenerationCount = ++s_DeadThreadGenerationCounts[exposedObjectGeneration];
if (exposedObjectGeneration > gcGenerationToTrigger && newDeadThreadGenerationCount >= generationCountThreshold)
{
Expand Down
3 changes: 3 additions & 0 deletions src/libraries/System.Runtime/tests/System/GCTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,9 @@ public static void Collect_Int()
{
GC.Collect(i);
}
// Also, expect GC.Collect(int.MaxValue) to work without exception since int.MaxValue represents
// a nongc heap generation (that is exactly what GC.GetGeneration returns for a non-gc heap object)
GC.Collect(int.MaxValue);
}

[Fact]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -986,9 +986,9 @@ public static void Run()
}

{
// Expecting this to be a frozen array, and reported as Gen2 by the GC
// Expecting this to be a frozen array, and reported as int.MaxValue by the GC
object val = AccessArray<C1>();
Assert.AreEqual(2, GC.GetGeneration(val));
Assert.AreEqual(int.MaxValue, GC.GetGeneration(val));

val = typeof(ClassWithTemplate<>).MakeGenericType(typeof(C4)).GetField("Array").GetValue(null);
Assert.AreEqual(0, GC.GetGeneration(val));
Expand Down
53 changes: 53 additions & 0 deletions src/tests/profiler/gc/nongcheap.cs
Original file line number Diff line number Diff line change
@@ -0,0 +1,53 @@
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.

using System;
using System.Runtime.CompilerServices;
using System.Threading;

namespace Profiler.Tests
{
class NonGCHeapTests
{
static readonly Guid GcAllocateEventsProfilerGuid = new Guid("EF0D191C-3FC7-4311-88AF-E474CBEB2859");

[MethodImpl(MethodImplOptions.NoInlining)]
static void AllocateNonGcHeapObjects()
{
// When this method is invoked, JIT is expected to trigger allocations for these
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might not work for ReadyToRun?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, disabled the test for crossgen

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not think that this is correct. Did you see the test actually failing with crossgen?

If I am reading the code correctly, this test should work with crossgen just fine. The string literals referenced by R2R code must be allocated on frozen heap. Otherwise, the tiering from R2R to Tier1 would work poorly - the tiering would be stuck with non-frozen string literals.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, you're absolutely right

// string literals and they're expected to end up in a nongc segment (also known as frozen)
Consume("string1");
Consume("string2");
Consume("string3");
Consume("string4");
Consume("string5");
Consume("string6");

int gen = GC.GetGeneration("string7");
if (gen != int.MaxValue)
throw new Exception("object is expected to be in a non-gc heap for this test to work");
}

[MethodImpl(MethodImplOptions.NoInlining)]
static void Consume(object o) {}

public static int RunTest(String[] args)
{
AllocateNonGcHeapObjects();
Console.WriteLine("Test Passed");
return 100;
}

public static int Main(string[] args)
{
if (args.Length > 0 && args[0].Equals("RunTest", StringComparison.OrdinalIgnoreCase))
{
return RunTest(args);
}

return ProfilerTestRunner.Run(profileePath: System.Reflection.Assembly.GetExecutingAssembly().Location,
testName: "NonGCHeapAllocate",
profilerClsid: GcAllocateEventsProfilerGuid);
}
}
}
23 changes: 23 additions & 0 deletions src/tests/profiler/gc/nongcheap.csproj
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<TargetFrameworkIdentifier>.NETCoreApp</TargetFrameworkIdentifier>
<OutputType>exe</OutputType>
<AllowUnsafeBlocks>true</AllowUnsafeBlocks>
<Optimize>true</Optimize>
<!-- This test provides no interesting scenarios for GCStress -->
<GCStressIncompatible>true</GCStressIncompatible>
<!-- The test launches a secondary process and process launch creates
an infinite event loop in the SocketAsyncEngine on Linux. Since
runincontext loads even framework assemblies into the unloadable
context, locals in this loop prevent unloading -->
<UnloadabilityIncompatible>true</UnloadabilityIncompatible>
<!-- Crossgen doesn't allocate string literals on non-gc heaps -->
<CrossGenTest>false</CrossGenTest>
</PropertyGroup>
<ItemGroup>
<Compile Include="$(MSBuildProjectName).cs" />
<ProjectReference Include="$(TestSourceDir)Common/CoreCLRTestLibrary/CoreCLRTestLibrary.csproj" />
<ProjectReference Include="../common/profiler_common.csproj" />
<CMakeProjectReference Include="$(MSBuildThisFileDirectory)/../native/CMakeLists.txt" />
</ItemGroup>
</Project>
1 change: 1 addition & 0 deletions src/tests/profiler/native/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ set(SOURCES
eventpipeprofiler/eventpipewritingprofiler.cpp
eventpipeprofiler/eventpipemetadatareader.cpp
gcallocateprofiler/gcallocateprofiler.cpp
nongcheap/nongcheap.cpp
gcbasicprofiler/gcbasicprofiler.cpp
gcprofiler/gcprofiler.cpp
getappdomainstaticaddress/getappdomainstaticaddress.cpp
Expand Down
5 changes: 5 additions & 0 deletions src/tests/profiler/native/classfactory.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
#include "eventpipeprofiler/eventpipewritingprofiler.h"
#include "getappdomainstaticaddress/getappdomainstaticaddress.h"
#include "gcallocateprofiler/gcallocateprofiler.h"
#include "nongcheap/nongcheap.h"
#include "gcbasicprofiler/gcbasicprofiler.h"
#include "gcprofiler/gcprofiler.h"
#include "handlesprofiler/handlesprofiler.h"
Expand Down Expand Up @@ -69,6 +70,10 @@ HRESULT STDMETHODCALLTYPE ClassFactory::CreateInstance(IUnknown *pUnkOuter, REFI
{
profiler = new GCAllocateProfiler();
}
else if (clsid == NonGcHeapProfiler::GetClsid())
{
profiler = new NonGcHeapProfiler();
}
else if (clsid == GCBasicProfiler::GetClsid())
{
profiler = new GCBasicProfiler();
Expand Down
74 changes: 74 additions & 0 deletions src/tests/profiler/native/nongcheap/nongcheap.cpp
Original file line number Diff line number Diff line change
@@ -0,0 +1,74 @@
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.

#include "nongcheap.h"

GUID NonGcHeapProfiler::GetClsid()
{
// {EF0D191C-3FC7-4311-88AF-E474CBEB2859}
GUID clsid = { 0xef0d191c, 0x3fc7, 0x4311, { 0x88, 0xaf, 0xe4, 0x74, 0xcb, 0xeb, 0x28, 0x59 } };
return clsid;
}

HRESULT NonGcHeapProfiler::Initialize(IUnknown* pICorProfilerInfoUnk)
{
Profiler::Initialize(pICorProfilerInfoUnk);

HRESULT hr = S_OK;
if (FAILED(hr = pCorProfilerInfo->SetEventMask2(
COR_PRF_ENABLE_OBJECT_ALLOCATED | COR_PRF_MONITOR_OBJECT_ALLOCATED,
cshung marked this conversation as resolved.
Show resolved Hide resolved
COR_PRF_HIGH_BASIC_GC)))
{
printf("FAIL: ICorProfilerInfo::SetEventMask2() failed hr=0x%x", hr);
return hr;
}

return S_OK;
}

HRESULT STDMETHODCALLTYPE NonGcHeapProfiler::ObjectAllocated(ObjectID objectId, ClassID classId)
{
COR_PRF_GC_GENERATION_RANGE gen;
HRESULT hr = pCorProfilerInfo->GetObjectGeneration(objectId, &gen);

// non-GC objects (same for GC.GetGeneration() API) have generation = -1
if (gen.generation == (COR_PRF_GC_GENERATION)INT32_MAX)
{
if (!FAILED(hr))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about calling this API to verify that it is a frozen object as well?

Copy link
Member Author

@EgorBo EgorBo Apr 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my understanding we sort of ignore these old Frozen* profiler APIs as we re-branded Frozen as NonGC. For the same reason we introduce a new API to traverse frozen objects and ignore existing EnumModuleFrozenObjects

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignore is probably fine when we were still designing, but it is really lousy from a testing perspective. It should either supposed to work or it doesn't. If it is supposed to work, and we are not testing it, it would be a test hole. If it is not supposed to work, then we should update the code to make it fails. If we wanted to depreciate old APIs in favor of new ones, we should make that clear in the documentation. Either way, something is missing.

{
// We expect GetObjectGeneration to return an error (CORPROF_E_NOT_GC_OBJECT)
// for non-GC objects.
_failures++;
}
_nonGcHeapObjects++;
if (gen.rangeLength != 0 || gen.rangeLengthReserved != 0 || gen.rangeStart != 0)
{
_failures++;
}
}
else if (FAILED(hr))
{
_failures++;
}
return S_OK;
}

HRESULT NonGcHeapProfiler::Shutdown()
{
if (_failures > 0)
{
printf("PROFILER TEST FAILS\n");
}
else if (_nonGcHeapObjects == 0)
{
printf("PROFILER TEST FAILS: non-GC heap objects were not allocated\n");
}
else
{
printf("PROFILER TEST PASSES\n");
}
printf("Non-GC objects allocated: %d\n", (int)_nonGcHeapObjects);
printf("PROFILER TEST PASSES\n");
fflush(stdout);
return S_OK;
}
24 changes: 24 additions & 0 deletions src/tests/profiler/native/nongcheap/nongcheap.h
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.

#pragma once

#include "../profiler.h"

class NonGcHeapProfiler : public Profiler
{
public:
NonGcHeapProfiler() : Profiler(),
_nonGcHeapObjects(0),
_failures(0)
{}

static GUID GetClsid();
virtual HRESULT STDMETHODCALLTYPE Initialize(IUnknown* pICorProfilerInfoUnk);
virtual HRESULT STDMETHODCALLTYPE ObjectAllocated(ObjectID objectId, ClassID classId);
virtual HRESULT STDMETHODCALLTYPE Shutdown();

private:
std::atomic<int> _nonGcHeapObjects;
std::atomic<int> _failures;
};