[mono][aot] Refactor deduplication to use enum instead of flags #85384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run runtime-ioslike,runtime-ioslikesimulator,runtime-wasm |
|
Azure Pipelines successfully started running 3 pipeline(s). |
This was referenced Apr 26, 2023
|
/azp run runtime-ioslike,runtime-ioslikesimulator,runtime-wasm |
|
Azure Pipelines successfully started running 3 pipeline(s). |
lambdageek
approved these changes
Apr 27, 2023
This was referenced Apr 27, 2023
|
/azp run runtime-ioslike,runtime-ioslikesimulator,runtime-wasm |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
The change has been tested by measuring the number of methods and size on HelloiOS app, and also by evaluating the speed on a WASM console sample app. Here are the results:
|
|
/azp run runtime-ioslike,runtime-ioslikesimulator,runtime-wasm |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
The failures are known issues and shouldn't be related. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contributes to #83973. It doesn't change the behavior and improves code maintenance by using deduplication enum instead of multiple flags.
Related PRs are #84304 and #85044.