Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove comment in ZipFile.Create.cs #86927

Merged
merged 2 commits into from
May 31, 2023
Merged

Remove comment in ZipFile.Create.cs #86927

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
94f033e
Remove comment in ZipFile.Create.cs
IDisposable May 30, 2023
6a6102c
Remove compressionLevel validation comment
IDisposable May 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions src/libraries/System.IO.Compression.ZipFile/src/System/IO/Compression/ZipFile.Create.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -459,10 +459,7 @@ private static void DoCreateFromDirectory(string sourceDirectoryName, Stream des
throw new ArgumentOutOfRangeException(nameof(compressionLevel));
}

// Rely on Path.GetFullPath for validation of sourceDirectoryName and destinationArchive

// Checking of compressionLevel is passed down to DeflateStream and the IDeflater implementation
// as it is a pluggable component that completely encapsulates the meaning of compressionLevel.
// Rely on Path.GetFullPath for validation of sourceDirectoryName

sourceDirectoryName = Path.GetFullPath(sourceDirectoryName);

Expand Down