[nativeaot][ios] Improve Native AOT test coverage on apple mobile platforms #89301
Conversation
kotlarmilos
requested review from
akoeplinger,
filipnavara,
MichalStrehovsky and
ivanpovazan
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas Issue DetailsThis PR improves Native AOT test coverage on apple mobile platforms by enabling TestLinqExpressions test. Additionally, it enables tests execution on maccatalyst and adds more runtime tests from the subset.
|
|
/azp run runtime-ioslike,runtime-ioslikesimulator,runtime-maccatalyst |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run runtime-ioslike,runtime-ioslikesimulator,runtime-maccatalyst |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run runtime-ioslikesimulator |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-ioslikesimulator |
|
No commit pushedDate could be found for PR 89301 in repo dotnet/runtime |
|
/azp run runtime-ioslikesimulator |
|
No commit pushedDate could be found for PR 89301 in repo dotnet/runtime |
|
/azp run runtime-ioslike,runtime-ioslikesimulator |
|
No commit pushedDate could be found for PR 89301 in repo dotnet/runtime |
|
/azp run runtime-ioslike,runtime-ioslikesimulator |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run runtime-ioslike,runtime-ioslikesimulator |
|
Azure Pipelines successfully started running 2 pipeline(s). |
…milos/runtime into improvement/nativeaot-smoke-tests
|
/azp run runtime-maccatalyst |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…milos/runtime into improvement/nativeaot-smoke-tests
|
Any final thoughts before we merge this PR? |
File issue on the disabled tests and add a link to it in all places where the tests are disabled? I assume that most of the tests are disabled due to bugs that we want to fix. |
Will do, thanks. The tests shouldn't necessarily fail, but the current infrastructure doesn't support multiple app bundles in a single test directory. In the case of Mono, a single app bundle is created, and test wrappers are generated to pass the main entry using an environment variable. However, with Native AOT, separate app bundles are required for each test project since the main entry point can't be passed as an environment variable. We plan to implement it as a follow-up. |
|
+1 to what Jan said - most of the disabled test look like something we should be running, we just have an infra problem. We should have an issue to track the infra problem and link it from all the disabling lines. Might want to put it on a separate line so that instead of this: <!-- Requires the framework to also be compiled with UseSystemResourceKeys -->
<CLRTestTargetUnsupported Condition="'$(IlcMultiModule)' == 'true' or '$(TargetsAppleMobile)' == 'true'">true</CLRTestTargetUnsupported>We have this: <!-- Requires the framework to also be compiled with UseSystemResourceKeys -->
<CLRTestTargetUnsupported Condition="'$(IlcMultiModule)' == 'true'">true</CLRTestTargetUnsupported>
<!-- Test infra issue on apple devices https://... -->
<CLRTestTargetUnsupported Condition="'$(TargetsAppleMobile)' == 'true'">true</CLRTestTargetUnsupported>
|
|
/azp run runtime-ioslike,runtime-ioslikesimulator |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
The failures are known and shouldn't be related. |
ghost
locked as resolved and limited conversation to collaborators
This PR improves Native AOT test coverage on apple mobile platforms by enabling TestLinqExpressions test. Additionally, it enables
tests execution on maccatalyst and addsmore runtime tests from the subset.Fixes #89168