Added missing *Async overrides to TlsStream

[ManickaP]

#82644 replaced custom IAsyncResult with call to ReadAsync on BufferedReadStream. But TlsStream doesn't have ReadAsync and the call went to the base class NetworkStream.ReadAsync effectively bypassing SslStream.Decrypt of the data.

I added Read/WriteAsync overrides to call into _sslStream as is expected.

Note that we do not have any coverage for SSL enabled SMTP. So in order to add tests for this, I'll need add support for SSL into LoopbackSmtpServer. @karelz this might take some time, so let me know, if you want to move forward with this fix with just local validation and do the test afterwards.

Fixes #91377

[ghost]

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

---

#82644 replaced custom IAsyncResult with call to ReadAsync on BufferedReadStream. But TlsStream doesn't have ReadAsync and the call went to the base class NetworkStream.ReadAsync effectively bypassing SslStream.Decrypt of the data.

I added Read/WriteAsync overrides to call into _sslStream as is expected.

Note that we do not have any coverage for SSL enabled SMTP. So in order to add tests for this, I'll need add support for SSL into LoopbackSmtpServer. @karelz this might take some time, so let me know, if you want to move forward with this fix with just local validation and do the test afterwards.

Fixes #91377

Author:	ManickaP
Assignees:	-
Labels:	area-System.Net
Milestone:	-

[stephentoub]

Ouch, sorry about that. Thanks for tracking it down.

[ManickaP]

We agreed with @karelz that we're ok with manual validation for this PR and to file an issue for the tests (#91776).

[karelz]

Agreed, let's push the fix into 8.0 with manual validation. And let's file a tracking issue to add the automated tests during 9.0 - we can then prioritize it appropriately against other work items we will have based on cost, value and risk we impose if we do not have the automation.

[ManickaP]

Build error is #91705

[stephentoub]

/backport to release/8.0

[github-actions]

Started backporting to release/8.0: https://github.com/dotnet/runtime/actions/runs/6122263567

[wfurt]

this looks like major test gap. We should look into it IMHO. I know @filipnavara had more insight to additional test gaps.