Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/8.0] Added missing *Async overrides to TlsStream #91794

Merged
merged 1 commit into from
Sep 14, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Sep 8, 2023

Backport of #91750 to release/8.0

Fixes #91377

/cc @stephentoub @ManickaP

Customer Impact

Regression against 7.0. Unable to send email via SmptClient over TLS.

Testing

Manual test.

Note: Adding automated test is involved work - tracked in #91776.

Risk

Low

@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Sep 8, 2023
@filipnavara filipnavara added area-System.Net and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Sep 8, 2023
@ghost
Copy link

ghost commented Sep 8, 2023

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #91750 to release/8.0

/cc @stephentoub @ManickaP

Customer Impact

Testing

Risk

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

Author: github-actions[bot]
Assignees: -
Labels:

area-System.Net

Milestone: -

@karelz karelz added this to the 8.0.0 milestone Sep 8, 2023
Copy link
Member

@ManickaP ManickaP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did one last round of verification on the fix and the repro-case passes with this change.

@karelz karelz added the Servicing-consider Issue for next servicing release review label Sep 12, 2023
@karelz
Copy link
Member

karelz commented Sep 12, 2023

@artl93 this is ready for your approval -- it is a regression in 8.0.

@artl93
Copy link
Member

artl93 commented Sep 13, 2023

M2 approved.

@artl93 artl93 added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Sep 13, 2023
@carlossanlop carlossanlop merged commit 54679f4 into release/8.0 Sep 14, 2023
107 of 112 checks passed
@carlossanlop carlossanlop deleted the backport/pr-91750-to-release/8.0 branch September 14, 2023 00:05
@radical radical mentioned this pull request Sep 26, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Oct 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Net Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants