Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mono][interp] Fix calling of static delegates with simd arguments #92927

Merged
merged 3 commits into from
Oct 6, 2023
Merged

[mono][interp] Fix calling of static delegates with simd arguments #92927

merged 3 commits into from
Oct 6, 2023

Commits on Oct 3, 2023

  1. [mono][interp] Small refactoring to make the code clearer 

    Previous code was checking if we should have already pushed a dreg, to compute the correct position of the argument on the stack. Save pointer to args directly instead.
    @BrzVlad
    BrzVlad committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    542bccc View commit details
    Browse the repository at this point in the history

  2. [mono][interp] Fix calling of static delegates with simd arguments 

    If we do a delegate call that translates to a static call, the delegate pointer that was passed needs to be skipped and we need to pass the actual arguments. However, the following arguments might not come immediately after the delegate pointer, if the first argument is simd aligned. Pass this information to MINT_CALL_DELEGATE so the correct offset of the arguments can be computed.
    @BrzVlad
    BrzVlad committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    e3bcb32 View commit details
    Browse the repository at this point in the history

  3. [mono][interp] Don't pass csignature to MINT_CALL_DELEGATE 

    Pass param_count directly
    @BrzVlad
    BrzVlad committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    f6baa58 View commit details
    Browse the repository at this point in the history