Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix options source gen test #93709

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Conversation

tarekgh
Copy link
Member

@tarekgh tarekgh commented Oct 19, 2023

Fixes #93592

@ghost
Copy link

ghost commented Oct 19, 2023

Tagging subscribers to this area: @dotnet/area-extensions-options
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #93592

Author: tarekgh
Assignees: -
Labels:

area-Extensions-Options

Milestone: -

@tarekgh tarekgh added this to the 9.0.0 milestone Oct 19, 2023
@tarekgh
Copy link
Member Author

tarekgh commented Oct 19, 2023

CC @eiriktsarpalis @krwq could you please have a quick look? Thanks!

@tarekgh
Copy link
Member Author

tarekgh commented Oct 19, 2023

CC @ericstj

@akoeplinger
Copy link
Member

/azp run runtime-linuxbionic

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@akoeplinger akoeplinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the runtime-linuxbionic failures are unrelated

@akoeplinger akoeplinger merged commit 8964171 into dotnet:main Oct 19, 2023
110 of 112 checks passed
@tarekgh
Copy link
Member Author

tarekgh commented Oct 19, 2023

Thanks @akoeplinger

@ericstj
Copy link
Member

ericstj commented Oct 20, 2023

Do we need to backport these test fixes to 8.0 to improve CI reliability in servicing?

@tarekgh
Copy link
Member Author

tarekgh commented Oct 20, 2023

/backport to release/8.0

@github-actions
Copy link
Contributor

Started backporting to release/8.0: https://github.com/dotnet/runtime/actions/runs/6590327192

@ghost ghost locked as resolved and limited conversation to collaborators Nov 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[mono][android] Failure in SourceGeneration.Unit.Tests
4 participants